Don't pass blocks around, pass CIDs instead about js-ipfs-bitswap HOT 4 CLOSED

I might be missing something, would be great if you could point to some code in the latest version of the PR where you think this would help.

from js-ipfs-bitswap.

With the perf PR reads from the store are much more efficient amd will only happen when preparing for message sending. I don't believe that the suggested approach here would help regarding performance in any way.

from js-ipfs-bitswap.

With the perf PR reads from the store

Ok, this might be new, because it wasn't like that before perf PR, the full blocks were being passed and put in the "MessageQueue" of each peer, waiting for async to pick it up.

I don't believe that the suggested approach here would help regarding performance in any way.

You don't think that putting a LRU cache for reads in IPFS-Repo can help perf? Could you elaborate? Think about all disk reads or even worse, when the store is actually behind a network (i.e. S3)

from js-ipfs-bitswap.

I don't know about the LRU cache we would need to benchmark this. I meant changing the way we pass blocks vs cids around at the moment.

from js-ipfs-bitswap.