Comments (3)
Hey there,
I am not sure what this ticket is about.
AWS subnets that are correctly tagged are auto-detected by the ALB Ingress Controller without any further configuration options.
This terraform module already grants all necessary IAM permissions to the process running the controller to ensure that tags on subnets can be read.
If I am missing the point here, I would kindly ask you to clarify your request.
Thanks for your time
-Benjamin-
from terraform-kubernetes-alb-ingress-controller.
Ticket is to include the tagging of the subnets as part of the aws-alb-ingress module.
kubernetes.io/role/internal-elb = 1
kubernetes.io/role/elb = 1
this seems to be an extra step for aws-alb to work out of the box, so my suggestion was to include that as part of this terraform module.
resource "aws_ec2_tag" "tag_public_subnets_aws_alb_ingress" {
count = length(module.network.public_subnets.ids)
resource_id = element(module.network.public_subnets.ids.*, count.index)
key = "kubernetes.io/role/elb"
value = "1"
}
resource "aws_ec2_tag" "tag_private_subnets_aws_alb_ingress" {
count = length(module.network.private_subnets.ids)
resource_id = element(module.network.private_subnets.ids.*, count.index)
key = "kubernetes.io/role/internal-elb"
value = "1"
}
from terraform-kubernetes-alb-ingress-controller.
Hi @patradinesh,
you are of course right that tagging of the subnets is a non-optional step if you want to utilize the ALB ingress controller.
I want to leave this logic out of this module, though. I think it's better fitted into the module that is responsible for creating the subnets (this is where other AWS tags that are necessary for Kubernetes interop have to be set as well!)
Reasons for not including the logic:
- Subnets might be added to your cluster's VPC after the ALB ingres controller has been deployed. Therefore: it is possible that not all subnets are known at the time when deploying the ALB ingress controller
- More than one ALB ingress controller may be deployed in one kubernetes cluster, but they would still share the subnets and utilize the same AWS tags
I am closing this ticket. If you fell like I have missed a must-have use-case, feel free to re-open it to restart the discussion.
Thanks for your time.
-Benjamin-
from terraform-kubernetes-alb-ingress-controller.
Related Issues (14)
- Throwing an error on terraform v0.12.7 HOT 1
- Load Balancer Controller support HOT 2
- [Feature Request] Support alb-ingress-controller v2.x.x HOT 3
- Connection Refused Error HOT 1
- provider kubernetes is undefined
- Plan and Destroy fails if EKS cluster doesn't exist (not created yet or already destroyed) HOT 4
- Unsupported argument
- Allow priority_class_name for kubernetes_deployment HOT 1
- Deprecated attribute: default_secret_name
- Dependency on KIAM HOT 6
- InvalidParameter on IAM Role and Policy HOT 3
- Error: Waiting for rollout to finish: 0 of 1 updated replicas are available... HOT 10
- Need to support depends_on parameters - Does not work with fargate HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-kubernetes-alb-ingress-controller.