Giter VIP home page Giter VIP logo

Comments (9)

francisadelante avatar francisadelante commented on July 16, 2024

yes it crashed!

from epcontactspicker.

antons81 avatar antons81 commented on July 16, 2024

bug confirmed.

from epcontactspicker.

antons81 avatar antons81 commented on July 16, 2024

if let contactsForSection = orderedContacts[sortedContactKeys[indexPath.section]] {
contact = EPContact(contact: contactsForSection[indexPath.row]) // crash is here
}
For example I have 6 contacts, but 2 of them in 1 section. When tap on cancel on search bar it recognizing as 5 contacts and crashing with error out of index

There is no issue when it's 1 section

from epcontactspicker.

roro95 avatar roro95 commented on July 16, 2024

I changede in EPContactPicker
public func searchBarCancelButtonClicked(searchBar: UISearchBar) {
searchBar.text = ""
dispatch_async(dispatch_get_main_queue(), {
//self.tableView.reloadData()
self.reloadContacts()
})
}

from epcontactspicker.

antons81 avatar antons81 commented on July 16, 2024

I tried it also it's still crash

from epcontactspicker.

ray1021 avatar ray1021 commented on July 16, 2024

I mark the line on func searchBarCancelButtonClicked
// searchBar.text = ""
it would not crash.

from epcontactspicker.

antons81 avatar antons81 commented on July 16, 2024

This not related to crash. Crash going from section & cell indexes

from epcontactspicker.

ray1021 avatar ray1021 commented on July 16, 2024

Because searchBar.text = "" will trigger func updateSearchResultsForSearchController ,
and it will call self.tableView.reloadData() , then trigger numberOfSectionsInTableView ,
in this case, resultSearchController.active is true , so section always return 1.

from epcontactspicker.

antons81 avatar antons81 commented on July 16, 2024

That didn't help anyway. It still crash

from epcontactspicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.