thread 'main' panicked at 'unsupported standard library' on tmkms Docker image about crates HOT 7 CLOSED

Fixed in #132

https://circleci.com/gh/tendermint/kms/362

from crates.

Grabbed this from the CircleCI container:

[developer@340a0b0b642b project]$ /usr/bin/ldd --version
ldd (GNU libc) 2.17
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
[developer@340a0b0b642b project]$ echo $?
0

from crates.

Looks like the problem is the string glibc does not appear anywhere in the output:

https://github.com/iqlusioninc/crates/blob/master/zeroize/build.rs#L89

from crates.

I just saw #134. I think a better way for library detection is needed, depending on the output of --version to determine library type is ought to be problematic. Though unlikely for some time in the future, maybe if this becomes an issue again we can try to do something proper there.

from crates.

Offhand I'm not sure of a better way. I guess we can see if other edge cases come up.

Hopefully eventually either support for older versions of glibc/musl can be dropped, or Rust will stabilize the LLVM intrinsics needed to securely zero memory so this crate doesn't even need to exist.

from crates.

Well, one thing did just come to mind... information about the libc a crate is being linked against is available at compile time via the target_env attribute, which on Linux is either gnu (for glibc) or musl, so that could at least eliminate build.rs guesswork there.

You're right ldd is still a bad way of detecting the version as it will probably break cross-compilation which, as it were, is the way I was hoping to produce static musl builds.

from crates.

I was thinking something that could extract version information at compile time, something similar to M4 scripts testing version requirements of libraries. If target_env has it, then that's work already done for us.

from crates.