Comments (6)
That's a very good point. Since this is a derivative work of the PHP core implementation, the PHP license should apply.'ve updated the relevant files.
from password_compat.
Using PHP license makes sense, but it's incompatible with GPL, so many (open source) projects won't be able to use it.
from password_compat.
I agree with @gergoerdosi , MIT allowed broader adoption. In fact, I completely missed the "MIT" mention in composer.json before submitting this issue. I was looking for a LICENCE file, and/or a licence header comment in the code. Not sure if composer.json is visible enough (at least it wasn't for me :) )
from password_compat.
I did some research and found that PHP licensed code can be distributed in a GPL application, the distributor just needs to add an exception to the license. I would consider dual licensing this code though (PHP and GPL), so it would be easier to use it in projects.
from password_compat.
Or use MIT as @nicolas-grekas suggests, it's GPL compatible.
from password_compat.
I've reverted it back to the MIT license. I wanted to use the PHP license, because it's a derivative of the core implementation. But at the same time, I own that copyright, so I can relicense it as I see fit. So I'm putting it out as MIT.
from password_compat.
Related Issues (20)
- password_verify fails for hashes from crypt() HOT 3
- mysqli_real_escape_string
- PASSWORD_ARGON2I Algo Support HOT 1
- Password verify issues HOT 1
- php7 Compatibility problem HOT 5
- PHPCompatibility ruleset for password_compat
- Trouble with PHP 5.6 & Password Verify HOT 1
- A HOT 1
- A
- Function not outputting the same hash as built-in function HOT 8
- Bcrypt issue HOT 1
- function_exists('PasswordCompat\\binary\\_strlen') needed? HOT 4
- password_hash("foo") returning false on 5.3.2-1ubuntu4.30 HOT 7
- Cannot verify the password after hashing HOT 1
- Suggestion: use *.phpt tests from php-src to improve compatibility
- Problem with verifiying the hashed password HOT 3
- Using the project on a newer version of PHP HOT 2
- This Repo HOT 7
- use password_compact in codeigniter HOT 2
- This lib on php 5.5 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from password_compat.