Crash in feed.js on_timeout about follow HOT 7 OPEN

@haberc this sounds like a bug but i do not believe follow supports following changes on cloudant at the moment as they don't use numbers for ids. This is something I was talking to @jhs about the other day. We do plan to support it and we'd love the help :)

from follow.

@jcrugzz it interestingly works very well with Cloudant already. Actually I am using nano to interact with my cloudant db and nano itself uses follow as a module.
https://cloudant.com/blog/using-cloudant-with-node-js

from follow.

I have made a quick fix, just to see where it takes me. So far I am happy with it.
I changed:

self.emit('timeout', {elapsed_ms:elapsed_ms, heartbeat:self.heartbeat, id:self.pending.request.id()});

To:

if (self.pending.request != null){
self.emit('timeout', {elapsed_ms:elapsed_ms, heartbeat:self.heartbeat, id:self.pending.request.id()});
} else {
self.emit('timeout', {elapsed_ms:elapsed_ms, heartbeat:self.heartbeat, id:""});
}

from follow.

I assume this will also affect CouchDB 2.0 (which inherits non-numeric sequence numbers from BigCouch)?

from follow.

I forked into https://github.com/voortwis/follow and added a couple of changes to support the array type of sequence response from bigcouch and using the second value as the 'since' value. I did not get to testing it properly, if any of you want to take a look and comment on it that would be nice.

from follow.

@voortwis could you fix your editior configuration so i can actually see the changes that you made in git? All I'm seeing his tab conversion churn so its hard to pick out what you actually changed. Trying to be consistent with whatever style/file format exists :).

from follow.

Okay, that was indeed ugly, (ignore whitespace in my editor switched on so I didn't notice).
I committed the original version and applied the changes again.

voortwis@86ddfa3

from follow.