Giter VIP home page Giter VIP logo

Comments (6)

burgrp avatar burgrp commented on June 17, 2024

Just found unhandled promise rejection in ParquetTransformer, line 268:

  _transform(row, encoding, callback) {
    if (row) {
      this.writer.appendRow(row).then(callback);
    } else {
      callback();
    }
  }

from parquetjs.

ZJONSSON avatar ZJONSSON commented on June 17, 2024

@burgrp you will also find the proposed fix in the reference above, from Feb 1 2018

from parquetjs.

burgrp avatar burgrp commented on June 17, 2024

Thanks @ZJONSSON . It's a pity, it's not merged yet.

from parquetjs.

ed-sparkes avatar ed-sparkes commented on June 17, 2024

Any chance of getting this fix merged and new version published ?

from parquetjs.

emranuddin75 avatar emranuddin75 commented on June 17, 2024

Its a useful change to merge in, and would be very much appreciated to capture the rejection rather than silently dying.
Let me now when that would likely to be merged so that i can harden the code.

from parquetjs.

sambonbonne avatar sambonbonne commented on June 17, 2024

Does anyone have a workaround to handle promise rejection?

from parquetjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.