ForerunnerDB does not work with IE 8 about forerunnerdb HOT 8 CLOSED

Hmm, those catch, continue and delete calls are in LocalForage it looks like?

Filter calls are definitely part of Forerunner collections though. A polyfill seems like something we should add with a particular build so that when building Forerunner the user can select "IE8 compat" or something like that then we can generate a build with the polyfill in it. I would rather not add code needlessly but agree IE8 compat would be a nice added extra.

Just so you are aware, a custom build page is in development that will allow the user to select the modules they want in their build and then a file is generated for them (or grabbed from cache of already generated files more likely).

from forerunnerdb.

They have already replaced, yesterday I took localforage from them, and they already use quoted syntax.

I'm pleased to hear the custom build page is coming!

Saying about 'IE8 compat' I would prefer the opposite. By default the polyfill is included (as it is very small), but the user is able to exclude IE8 support, if they want. This is because IE8 still takes 3.18% of global usage. I prefer reliability vs tiny overhead.

from forerunnerdb.

I'm happy for the flag to be on by default. When the custom build page is ready I'll reply here to let you know.

from forerunnerdb.

Cool! Just don't forget to replace for quoted syntax: 'catch', etc... Otherwise IE8 compat will not work!

from forerunnerdb.

Will have to wait for localforage to do that in their repo because it's in
their code. Did you say they have fixed already?
On 26 Nov 2014 22:54, "edwardcoolson" [email protected] wrote:

Cool! Just don't forget to replace for quoted syntax: 'catch', etc...
Otherwise IE8 compat will not work!

—
Reply to this email directly or view it on GitHub
#19 (comment)
.

from forerunnerdb.

Yes, it seems so. They only use double quotes 😄.

from forerunnerdb.

So there is more to this story. After updating I indeed see their change in the source but if I run closure compiler over the code the compiler converts back to dot notation again!

It seems the only way to ensure IE8 compat is to deliver a non-closure-compiled version of the code?

from forerunnerdb.

Actually ignore that last comment, I found the issue and have raised it on localforage: localForage/localForage#220 (comment)

from forerunnerdb.