CKEDITOR5 V25.0.0 support? about ckeditor5-math HOT 14 CLOSED

I tested v25.0.0.
Well done.
Thank you!!

from ckeditor5-math.

Closing per #26

from ckeditor5-math.

I'm doing my update to v25 and noticed this package causes the duplicated package error. The npm ls for ckeditor5-math looks like this:

├─┬ [email protected]
│ ├─┬ @ckeditor/[email protected]
│ │ ├── @ckeditor/[email protected] deduped
│ │ ├── @ckeditor/[email protected] deduped
│ │ └── @ckeditor/[email protected] deduped
│ ├─┬ @ckeditor/[email protected]
│ │ ├── @ckeditor/[email protected] deduped
│ │ ├── @ckeditor/[email protected] deduped
│ │ └── [email protected] deduped
│ ├─┬ @ckeditor/[email protected]
│ │ ├── @ckeditor/[email protected] deduped
│ │ └── [email protected] deduped
│ ├─┬ @ckeditor/[email protected]
│ │ ├── @ckeditor/[email protected] deduped
│ │ ├── @ckeditor/[email protected] deduped
│ │ └── [email protected] deduped
│ ├─┬ @ckeditor/[email protected]
│ │ ├── @ckeditor/[email protected] deduped
│ │ ├── @ckeditor/[email protected] deduped
│ │ └── @ckeditor/[email protected] deduped
│ ├─┬ @ckeditor/[email protected]
│ │ └── [email protected] deduped
│ └─┬ @ckeditor/[email protected]
│   ├── @ckeditor/[email protected] deduped
│   ├── @ckeditor/[email protected] deduped
│   ├─┬ @ckeditor/[email protected]
│   │ ├── @ckeditor/[email protected] deduped
│   │ ├── @ckeditor/[email protected] deduped
│   │ ├── @ckeditor/[email protected] deduped
│   │ └── [email protected] deduped
│   ├── @ckeditor/[email protected] deduped
│   ├── @ckeditor/[email protected] deduped
│   └── [email protected] deduped

I tried removing the explicit core and engine dependencies but still got the duplicated packages error.

from ckeditor5-math.

Math plugin must be in the same version as CKEditor 5 or vice versa. I will try update dependencies and release new version today.

from ckeditor5-math.

I failed upgrade to v25.0.0. CKEditor Modules cannot be resolved and this needs more debugging than normally. Unfortunately I don't have time to find solution for now.

from ckeditor5-math.

I was able to use v25.0.0 successfully when I tried.

https://www.npmjs.com/package/@peergrade/ckeditor5-math
https://github.com/eduflow/ckeditor5-math/tree/eduflow-v25.0.0

I will PR this change

from ckeditor5-math.

@archonic @isaul32

You may be using a build with different packages than me - I'm not getting the same error. 🤷

Question:

• When these dependency issues happen, it's when creating the ckeditor5 build itself, right? (Not this repo itself)

• Have you tried rm -rf node_modules and npm i again?

• Have you tried yarn instead? (Interestingly, ckeditor recommends it for troubleshooting)

  

I've had similar issues and fixed them via a clean build

from ckeditor5-math.

1. Yes
2. Yes
3. I use Yarn and yarn link

I merged PR but I can’t publish new version to NPM (no access to computer for while). Can you @tony do it if I give permission to repo and NPM?

from ckeditor5-math.

I merged PR but I can’t publish new version to NPM (no access to computer for while). Can you @tony do it if I give permission to repo and NPM?

Yep. NPM user is tony (same name)

from ckeditor5-math.

I merged PR but I can’t publish new version to NPM (no access to computer for while). Can you @tony do it if I give permission to repo and NPM?

Yep. NPM user is tony (same name)

Thank you. Permissions are now given.

from ckeditor5-math.

@isaul32

25.0.0 published on npm

On GH, when pushing the tag

ckeditor5-math on  master ❯ git push --tag origin v25.0.0
ERROR: Permission to isaul32/ckeditor5-math.git denied to tony.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

from ckeditor5-math.

@isaul32

25.0.0 published on npm

On GH, when pushing the tag

ckeditor5-math on  master ❯ git push --tag origin v25.0.0
ERROR: Permission to isaul32/ckeditor5-math.git denied to tony.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Looks like invitation is awaiting your response. Did you get invitation email?

from ckeditor5-math.

Looks like invitation is awaiting your response. Did you get invitation email?

That was it. Accepted and pushed the tag: https://github.com/isaul32/ckeditor5-math/tree/v25.0.0

from ckeditor5-math.

@DiggingLab Excellent! Enjoy!

from ckeditor5-math.