Comments (5)
NailxSharipov
commented on June 12, 2024
1
I'll see this example. Most of the time you will get this failure if a path
has self intersections.
…On Wed, 4 Aug 2021 at 19:12, Kenzan Hase ***@***.***> wrote:
I try to debug the triangulation of geojson's multipolygon features
<https://github.com/bathymetric-cam/bathymetric-cam-ios/blob/main/bathymetry/AR/ARBathymetryNode.swift#L110>,
and experience a crash due to the assertionFailure
<https://github.com/iShape-Swift/iShapeTriangulation/blob/master/Sources/iShapeTriangulation/Triangulation/PlainShape/PlainShape%2BLayout.swift#L479>
.
How can I avoid the assertionFailure?
Since the triangulation logic is a bit complicated for me to get the
picture, I'm not very sure how that works.
Here is a sample project
<https://github.com/kenzan8000/iShapeTriangulationSample/blob/main/iShapeTriangulationSample/AppDelegate.swift#L17>
reproducing the crash.
[image: Screen Shot 2021-08-04 at 10 19 49 PM]
<https://user-images.githubusercontent.com/225808/128189785-113a31b8-fb9b-499a-815d-c12e2ace432c.png>
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XPMSCSWZ5FDRUSDKJWITT3FDFLANCNFSM5BRHOUCQ>
.
from ishapetriangulation.
kenzan8000
commented on June 12, 2024
@NailxSharipov Drew the path on qgis app. It looks like there are intersections as you said above.
It would be great if the library would throw the error instead of calling assertionFailure.
Anyway, I'll be removing the intersections from the geojson files. (and maybe making the pull request)
from ishapetriangulation.
NailxSharipov
commented on June 12, 2024
I thoght about your words and throwing an exception is looking good.
Right now this algorithm is not support self intersections, cause I hadn't
this purporse. In other hand it's not so hard to implement.
We are spliting path into separate "correct" pathes. As the result we will
get a clock-wise and counter clock-wise pathes. Then we should decide which
of them we must triangulate all of them or just clock-wise pathes. I think
it must be kind of enum parameter with this rule logic.
…On Wed, 4 Aug 2021 at 20:53, Kenzan Hase ***@***.***> wrote:
@NailxSharipov <https://github.com/NailxSharipov> Drew the path on qgis
app. It looks like there are two intersections as you said above.
[image: Screen Shot 2021-08-05 at 12 37 55 AM]
<https://user-images.githubusercontent.com/225808/128210674-b83fb55f-4355-47fc-a329-9040bcc55efc.png>
It would be great if the library would throw the error instead of calling
assertionFailure.
Anyway, If so, I'll be working on the pull request or removing the
intersections from geojson files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XPMWER5MEEDVGZP6O7SDT3FO6VANCNFSM5BRHOUCQ>
.
from ishapetriangulation.
kenzan8000
commented on June 12, 2024
Oh, that sounds really complicated to work on the triangulation that the source path has the intersections in it.
We are spliting path into separate "correct" pathes. As the result we will
get a clock-wise and counter clock-wise pathes. Then we should decide which
of them we must triangulate all of them or just clock-wise pathes.
Just throwing the error when the path isn’t “correct” would be simpler.
from ishapetriangulation.
NailxSharipov
commented on June 12, 2024
Finally, I've added try/catch functionality with the detection problem mechanism. Now all functions like triangulation Delaunay throw an exception with the detail information what's going wrong
from ishapetriangulation.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ishapetriangulation.