Giter VIP home page Giter VIP logo

Comments (12)

gdr-at-ms avatar gdr-at-ms commented on May 28, 2024

Thanks for the suggestion.
It is noteworthy that this is an issue that divides reasonable people, especially the larger C++ community, in many ways. Some people wonder if we should similarly systematically highlight verbs and nouns in every English sentence we write :-)
For now, we are doing without syntax highlighting, but we will definitely keep syntax highlighting in mind (e.g. comments formatted differently).

The issue about fenced code block syntax is more substantive, I think. It would require lot of work to fix, but I suspect having an open issue won't hurt. Thanks!

from cppcoreguidelines.

Kristine1975 avatar Kristine1975 commented on May 28, 2024

Just for the record: It apparently (I havent't tested it) is possible to turn off syntax highlighting in Github:

  1. Install the Stylish browser-addon (Firefox, Chrome).
  2. Use this stylesheet.

from cppcoreguidelines.

torbjoernk avatar torbjoernk commented on May 28, 2024

FYI: there is already a massive PR for this: #96

from cppcoreguidelines.

Liryna avatar Liryna commented on May 28, 2024

@torbjoernk ty, I haven't found this issue before making the PR :D
The PR is massive because I removed all first tabulations that become useless after moving to syntax highlighting.

@gdr-at-ms,
The PR should be review quickly or there will be easily some conflict to fix.

from cppcoreguidelines.

gdr-at-ms avatar gdr-at-ms commented on May 28, 2024

@Liryna Yes; we have all been busy this week; will get to that.

from cppcoreguidelines.

AndrewPardoe avatar AndrewPardoe commented on May 28, 2024

We prefer the simple, non-syntax highlighted code blocks for the time being. Thank you, @Liryna, for making the PR but we're not merging it at the time. Sorry!

from cppcoreguidelines.

tkruse avatar tkruse commented on May 28, 2024

Since @gdr-at-ms said "The issue about fenced code block syntax is more substantive, I think. It would require lot of work to fix, ..."
I hope you realize you can take the PR by @Liryna, then run find/replace

```c++\n -> ```\n

and you're done.

from cppcoreguidelines.

skyrpex avatar skyrpex commented on May 28, 2024

what's the reason for not using syntax highlighting in the documentation?

from cppcoreguidelines.

blakehawkins avatar blakehawkins commented on May 28, 2024

@skyrpex not all flavors of markdown support such a thing. In a word: portability.

from cppcoreguidelines.

tkruse avatar tkruse commented on May 28, 2024

Regarding mere fencing: Note there is a tool that reformats markdown: https://github.com/wooorm/mdast. Getting the file to be idempotent would be very useful.

It's not quite the case yet, but in case you get interested, I get close with this .mdastrc:

{
  "settings": {
    "bullet": "*",
    "listItemIndent": "1",
    "strong": "*",
    "emphasis": "*"
  }
}

By adding "fences": true this will create fences (mostly correct, a handful of cases must be fixed manually).

Regarding syntax highlighting, note I could get this on github pages via Jekyll configuration: #146 without changing the source.

from cppcoreguidelines.

gdr-at-ms avatar gdr-at-ms commented on May 28, 2024

Thanks for the suggestion, @tkruse

from cppcoreguidelines.

novasdream avatar novasdream commented on May 28, 2024

to be portable dont need be ugly

from cppcoreguidelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.