Giter VIP home page Giter VIP logo

Comments (8)

DavidGOrtega avatar DavidGOrtega commented on July 22, 2024 1

If you are wondering what is does is prevent other libraries to output in std with console.log. Take into account that console.log is used even is you dont want to

from cml.

DavidGOrtega avatar DavidGOrtega commented on July 22, 2024 1

Yeah, JS and its weirdness. Mostly all the logging libs do this internally

from cml.

0x2b3bfa0 avatar 0x2b3bfa0 commented on July 22, 2024 1

I plan to create a new follow-up epic from #703 and we can include all the relevant issues there.

from cml.

0x2b3bfa0 avatar 0x2b3bfa0 commented on July 22, 2024

cml/bin/cml-pr.js

Lines 3 to 4 in c61fe70

const print = console.log;
console.log = console.error;

🤯
#define struct union
#define if while
#define else
#define break
#define if(x)
#define double float
#define volatile

#define M_PI 3.2f
#undef FLT_MIN
#define FLT_MIN (-FLT_MAX)
#define floor ceil
#define isnan(x) false
#define true ((__LINE__&15)!=15)
#define true ((rand()&15)!=15)
#define if(x) if ((x) && (rand() < RAND_MAX * 0.99))

#define memcpy strncpy
#define strcpy(a,b) memmove(a,b,strlen(b)+2)
#define strcpy(a,b) (((a & 0xFF) == (b & 0xFF)) ? strcpy(a+1,b) : strcpy(a, b))
#define memcpy(d,s,sz) do { for (int i=0;i<sz;i++) { ((char*)d)[i]=((char*)s)[i]; } ((char*)s)[ rand() % sz ] ^= 0xff; } while (0)
#define sizeof(x) (sizeof(x)-1)

from cml.

DavidGOrtega avatar DavidGOrtega commented on July 22, 2024

@0x2b3bfa0 I dont fully follow you 😁

from cml.

0x2b3bfa0 avatar 0x2b3bfa0 commented on July 22, 2024

Thanks! I was wondering (admittedly, with a bit of humor) if we could avoid monkey-patching once we improve logging. The current approach is equally useful and puzzling if you overlook those lines.

from cml.

0x2b3bfa0 avatar 0x2b3bfa0 commented on July 22, 2024

@DavidGOrtega, feel free to create a new issue starting from the following template and elaborating on each idea, if opportune:

Follow-up of #22

  • wrap specific CI vendor capabilities
  • heartbeats (in openmetrics format?)
  • file configurable
  • integration with studio

The proposal would be use winston and a configurable file. We can also collect runner heartbeat using openmetrics format.

from cml.

DavidGOrtega avatar DavidGOrtega commented on July 22, 2024

This could be maintained as an epic?

from cml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.