Giter VIP home page Giter VIP logo

Comments (7)

DavidGOrtega avatar DavidGOrtega commented on August 24, 2024

dvc-cml should not be handling this anymore, aside the exceptions like gs and ssh.
The code does nothing but warn so its removed in next PR delegating the responsibility to DVC.
In the case of gs and ssh it has to transform the json content inside the env variable into a file that gs is looking for. Something similar in ssh, the given key has to be added.

from cml.

dmpetrov avatar dmpetrov commented on August 24, 2024

@DavidGOrtega you should not warn users if settings are not defined for a not default remote.

from cml.

dmpetrov avatar dmpetrov commented on August 24, 2024

This is how you can get the default remote from bash

dvc remote list | grep "^`dvc remote default`\t" | awk '{print($2)}'

from cml.

DavidGOrtega avatar DavidGOrtega commented on August 24, 2024

Thats what Im saying. DVC-CML only needs to interface the secrets to the runner in case it has to do it.
Right now that only happens in gs and ssh.
For the rest the whole code is removed delegating it to dvc

from cml.

dmpetrov avatar dmpetrov commented on August 24, 2024

Log:

Fetch all history for all tags and branches
Setting DVC remote ...
S3 DVC remote found but no credentials found
Pulling from DVC remote ...
Failed pulling from DVC remote
Error: Command failed: dvc pull -f
Running dvc repro Dvcfile
ERROR: unexpected error - Unable to locate credentials

    at ChildProcess.exithandler (child_process.js:303:12)
    at ChildProcess.emit (events.js:310:20)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:443:11)
    at Socket.emit (events.js:310:20)
    at Pipe.<anonymous> (net.js:672:12) {
  killed: false,
  code: 255,
  signal: null,
  cmd: 'dvc pull -f'
}
##[error]Command failed: dvc repro Dvcfile            <--- THIS IS IN RED
WARNING: Dependency 'train.py' of 'Dvcfile' changed because it is 'modified'.
WARNING: Stage 'Dvcfile' changed.
.... [CONTINUE SOME PROCESS]

How the log ideally should look like:

Fetch all history for all tags and branches
Setting DVC remote ...
S3 DVC remote found but no credentials found
Pulling from DVC remote ...
Failed pulling from DVC remote
Error: Command failed: dvc pull -f
Running dvc repro Dvcfile
ERROR: unexpected error - Unable to locate credentials   <--- THIS IS IN RED
[EXIT NOW - NO REASON TO CONTINUE]
##[error]Process completed with exit code 1.               <--- THIS IS IN RED

from cml.

DavidGOrtega avatar DavidGOrtega commented on August 24, 2024

[EXIT NOW - NO REASON TO CONTINUE]
Its something that you have added right?

from cml.

dmpetrov avatar dmpetrov commented on August 24, 2024

@DavidGOrtega yes

from cml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.