Comments (5)
@josephfusco Haha, that shouldn't be in there! ;) I removed it in #26 , and thought I had removed it in main branch as well.
It will get removed once my pull request is cleared ;)
from jackbox.
Anything in particular you can point at that could be refactored?
from jackbox.
- Mix of soft tabs and hard tabs (I'd suggest using hard tabs here)
- Consistency with indentation
- Certain properties seems unnecessary
filter: brightness(100%);
-webkit-filter: brightness(100%);
^ What is the reason for this on the icons?
from jackbox.
Fixed with #21
from jackbox.
@ja1984 I am still wondering what the point of this is https://github.com/ja1984/jackbox/blob/master/jackbox.css#L48-L49 ? 😊
from jackbox.
Related Issues (18)
- Notifications sometimes stop counting down HOT 4
- Notifications sometimes start counting up HOT 2
- Change icons to svg HOT 4
- Mobile support HOT 1
- Add retry button with callback HOT 8
- Add settings to readme.md
- Use classList for adding/removing class
- Add per notification customizable settings HOT 3
- Bug: Multiple notifications, throws failed to execute 'removeChild' HOT 3
- Improve readme to explain css HOT 5
- Use flexbox to render notifications HOT 1
- Update demo button wording HOT 1
- Minified files HOT 4
- Change code to remove need for pollyfill
- Move buttons higher up in demo
- Add license and version to main file
- No notification in Android Chrome Browser HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jackbox.