Giter VIP home page Giter VIP logo

Comments (5)

ja1984 avatar ja1984 commented on August 27, 2024 1

@josephfusco Haha, that shouldn't be in there! ;) I removed it in #26 , and thought I had removed it in main branch as well.

It will get removed once my pull request is cleared ;)

from jackbox.

ja1984 avatar ja1984 commented on August 27, 2024

Anything in particular you can point at that could be refactored?

from jackbox.

josephfusco avatar josephfusco commented on August 27, 2024
  • Mix of soft tabs and hard tabs (I'd suggest using hard tabs here)
  • Consistency with indentation
  • Certain properties seems unnecessary
filter: brightness(100%);
-webkit-filter: brightness(100%);

^ What is the reason for this on the icons?

from jackbox.

ja1984 avatar ja1984 commented on August 27, 2024

Fixed with #21

from jackbox.

josephfusco avatar josephfusco commented on August 27, 2024

@ja1984 I am still wondering what the point of this is https://github.com/ja1984/jackbox/blob/master/jackbox.css#L48-L49 ? 😊

from jackbox.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.