Comments (3)
momoko-h
commented on July 22, 2024
Did you actually test this in vanilla? Admittedly I didn't; I just had a look at the original code https://github.com/dariusk/ja2/blob/876ccf5dfdad7e6821c5b26d6d783132ea1ab7a2/ja2/Build/Tactical/Interface%20Dialogue.c#L1828 and it sends only Fatima and Dimitri to the basement. Straciatella's code is still the same, except for cleanup/modernization changes.
However there's also a NPC_ACTION_PUT_PACOS_IN_BASEMENT case which looks broken in both vanilla and Straciatella because it sets the Z level to 0.
from ja2-stracciatella.
Inveriss
commented on July 22, 2024
Indeed, in Vanilla it's the same situation, but I've definitely seen Pacos many times in the basement of A10 and I actually saw him, but it was in the map editor. In the map editor in A10 basement he is added there.
I think he originally should be there, but perhaps someone forgot change 0 to 1.
from ja2-stracciatella.
lynxlynxlynx
commented on July 22, 2024
Or it was a design decision, it's impossible to say. I don't think we should do anything about it, this is clearly mod territory.
from ja2-stracciatella.
Related Issues (20)
- ALT+ENTER doesn't work anymore in the cheat mode HOT 2
- In game.json file function "all_drops_visible" is not working for weapons when "drop_everything" is set to false.
- If you dismiss from your squad NPC like Skyrider, John and Mary or runaway kid Joey, when you are escorting them, then the game freezes HOT 3
- In map editor if you press space key when you are in civilian "merc att" tab, then the game crashes HOT 3
- Increas the displayed character limit, so that the full lines in AIM and MERC Bios is useable. HOT 3
- Nails and his leather jacket should be inseparable HOT 2
- Assigning doctor or repair tasks should put the content of the primary hand in the secondary instead of an inventory pocket
- Our GitHub actions require some attention HOT 6
- Access violation after recent EDT string loading update HOT 5
- compilation without MAGIC_ENUM doesn't work
- Sending Skyrider to Drassen before his dialogue ends crashes.
- Error message "JA2 Stracciatella quit unexpectedly" on boot. (MAC) HOT 5
- ALT+MOVEMENT in combat - wrong display or AP calculation.
- Enhancement idea - swap main hand weapon to melee/barehand-empty, stealing case
- Autobandage always fails first time: uncapable merc + collapsed merc.
- Dart gun does not work on player mercs in TB combat.
- Not TB movement and hand icon - maintain running with use of CTRL+ hand icon. HOT 2
- Compiling on MSYS2 HOT 2
- Underground levels don't show on the strategic screen
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ja2-stracciatella.