Improvement: force close method about winston-logstash HOT 4 CLOSED

+1 - it also makes unit/integration tests not close properly because it immediately calls setTimeout after an explicit close.

from winston-logstash.

Also there should probably be an event thrown when a flush completes, else you can't drain the log messages.

from winston-logstash.

This should be fixed now as it will not reconnect after close is called.

from winston-logstash.

I am using [email protected] and able to replicate this problem.

Code to replicate it:

const winston = require('winston')
require('winston-logstash')

const logger = new winston.Logger()

logger.add(winston.transports.Logstash, {
    host: 'localhost',
    max_connect_retries: -1, // -1 means retry forever.
    node_name: 'my node name',
    port: 28777
})

setTimeout(() => {
    logger.close()
}, 1000);

With max_connect_retries: -1, it never exits but with 0 it exits as expected after 1 second.

from winston-logstash.