Comments (5)
please test.
from jack.
Almost.
It used to be
PERFORMER=John Acock (harmonium and mellotron and piano)
PERFORMER=Phil Collins (guest and membranophone and percussion and vibraphone and additional)
PERFORMER=John Hackett (bell and flute and guest and synthesizer)
PERFORMER=Steve Hackett (acoustic guitar and autoharp and bell and electric guitar and harmonium and mellotron and vocals)
PERFORMER=Robin Miller (cor anglais and oboe)
PERFORMER=Mike Rutherford (12 string guitar and bass guitar and bass pedals and guest)
PERFORMER=Nigel Warren-Green (cello and solo)
Now it is
PERFORMER=John Acock (harmonium, mellotron, and piano)
PERFORMER=Phil Collins (guest, membranophone, percussion, vibraphone, and additional)
PERFORMER=John Hackett (bell, flute, guest, and synthesizer)
PERFORMER=Steve Hackett (acoustic guitar, autoharp, bell, electric guitar, harmonium, mellotron, and vocals)
PERFORMER=Robin Miller (cor anglais and oboe)
PERFORMER=Mike Rutherford (12 string guitar, bass guitar, bass pedals, and guest)
PERFORMER=Nigel Warren-Green (cello and solo)
Note the comma before "and", which is why MusicBrainz Picard still does not flag this file as perfectly tagged.
from jack.
better now?
from jack.
Perfect!
But sadly still different from how Picard would tag the same release.
Apparently, vocals and instruments need to be grouped separately, which makes sense.
Vocals need the word "vocals" as a suffix.
Also, "guest" and "additional" need to be the first word, and not be followed by a comma.
Ideally leading to
PERFORMER=Phil Collins (additional vocals)
PERFORMER=Phil Collins (guest membranophone, percussion and vibraphone)
Of course this all has nothing to do with the human_readable_list function which works as it should,
but rather with the MusicBrainz data parsing.
Thanks for making me read https://en.wikipedia.org/wiki/Ofxord_comma !
from jack.
Closing, the performer grouping is a separate issue.
from jack.
Related Issues (20)
- python3-mb: should not use the artist name as credited for directory names HOT 1
- wav support missing? HOT 4
- Getting 'Please install the eyeD3 module available from http://eyed3.nicfit.net/' when eyeD3 already installed. HOT 3
- Album art embedding HOT 18
- python3-mb: migrate to .jack4rc ? HOT 2
- python3-mb: musicbrainz_template() breaks smart metadata selection HOT 2
- python3-mb: group vocal and instrumental performers separately HOT 1
- Default to the Python 3 version of jack HOT 6
- negating a non-existing boolean option causes an exception HOT 2
- Reading the TOC of a disc can be slow HOT 4
- do we still need and want to support plugins? HOT 3
- support only python-discid as Python libdiscid wrapper HOT 4
- switch from dateparser to dateutil HOT 2
- download album art in the background, in parallel
- setuptools-scm is failing HOT 3
- m4a encoded files are not optimized for streaming HOT 1
- high res iTunes album art is no longer fetched
- We need more disambiguation options
- Build fails on current releases of Debian/Ubuntu systems. HOT 14
- Please add a manpage to the package. (File attached)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jack.