Giter VIP home page Giter VIP logo

Comments (5)

zzarne avatar zzarne commented on May 31, 2024

please test.

from jack.

pimzand avatar pimzand commented on May 31, 2024

Almost.

It used to be

PERFORMER=John Acock (harmonium and mellotron and piano)
PERFORMER=Phil Collins (guest and membranophone and percussion and vibraphone and additional)
PERFORMER=John Hackett (bell and flute and guest and synthesizer)
PERFORMER=Steve Hackett (acoustic guitar and autoharp and bell and electric guitar and harmonium and mellotron and vocals)
PERFORMER=Robin Miller (cor anglais and oboe)
PERFORMER=Mike Rutherford (12 string guitar and bass guitar and bass pedals and guest)
PERFORMER=Nigel Warren-Green (cello and solo)

Now it is

PERFORMER=John Acock (harmonium, mellotron, and piano)
PERFORMER=Phil Collins (guest, membranophone, percussion, vibraphone, and additional)
PERFORMER=John Hackett (bell, flute, guest, and synthesizer)
PERFORMER=Steve Hackett (acoustic guitar, autoharp, bell, electric guitar, harmonium, mellotron, and vocals)
PERFORMER=Robin Miller (cor anglais and oboe)
PERFORMER=Mike Rutherford (12 string guitar, bass guitar, bass pedals, and guest)
PERFORMER=Nigel Warren-Green (cello and solo)

Note the comma before "and", which is why MusicBrainz Picard still does not flag this file as perfectly tagged.

from jack.

zzarne avatar zzarne commented on May 31, 2024

better now?

from jack.

pimzand avatar pimzand commented on May 31, 2024

Perfect!

But sadly still different from how Picard would tag the same release.
Apparently, vocals and instruments need to be grouped separately, which makes sense.
Vocals need the word "vocals" as a suffix.
Also, "guest" and "additional" need to be the first word, and not be followed by a comma.
Ideally leading to
PERFORMER=Phil Collins (additional vocals)
PERFORMER=Phil Collins (guest membranophone, percussion and vibraphone)
Of course this all has nothing to do with the human_readable_list function which works as it should,
but rather with the MusicBrainz data parsing.

Thanks for making me read https://en.wikipedia.org/wiki/Ofxord_comma !

from jack.

pimzand avatar pimzand commented on May 31, 2024

Closing, the performer grouping is a separate issue.

from jack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.