Comments (4)
jackc
commented on September 10, 2024
Do you have any examples of this happening? pgx's use goroutines is fairly limited. Any panic that does occur in a pgx spawned goroutine is a bug. I'm concerned that arbitrarily rescuing panics could leave the system in an undefined state. IMO, better to let the application crash. Then fix the bug.
from pgx.
madisonchamberlain
commented on September 10, 2024
Yeah! This is the what I saw when it was panicking
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2672365]
goroutine 97522 [running]:
github.com/sigmacomputing/mono-go/multiplex/db.getSshConfigs.func1({0x36fc678?, 0xc02d2f38c0?}, {0x30b2203?, 0x36f54d0?}, {0xc02d2e0fc0?, 0x0?})
/go/src/github.com/sigmacomputing/mono-go/multiplex/db/pgx.go:3836 +0x45
github.com/jackc/pgconn.connect({0x36fc678, 0xc02d2f38c0}, 0xc02d39f440, 0xc02d2b55c0, 0x0)
/go/pkg/mod/github.com/jackc/[email protected]/pgconn.go:270 +0x1a3
github.com/jackc/pgconn.ConnectConfig({0x36fe7b8, 0xc02d3a28c0}, 0xc02d39f440)
/go/pkg/mod/github.com/jackc/[email protected]/pgconn.go:171 +0x515
github.com/jackc/pgx/v4.connect({0x36fe7b8, 0xc02d3a28c0}, 0xc02d39f200)
/go/pkg/mod/github.com/jackc/pgx/[email protected]/conn.go:222 +0x365
github.com/jackc/pgx/v4.ConnectConfig(...)
/go/pkg/mod/github.com/jackc/pgx/[email protected]/conn.go:113
github.com/jackc/pgx/v4/pgxpool.ConnectConfig.func1({0x36fc608?, 0xc02632b860?})
/go/pkg/mod/github.com/jackc/pgx/[email protected]/pgxpool/pool.go:232 +0x16a
github.com/jackc/puddle.(*Pool).constructResourceValue(...)
/go/pkg/mod/github.com/jackc/[email protected]/pool.go:558
github.com/jackc/puddle.(*Pool).CreateResource(0xc02d158200, {0x36fc608, 0xc02632b860})
/go/pkg/mod/github.com/jackc/[email protected]/pool.go:479 +0x9b
github.com/jackc/pgx/v4/pgxpool.(*Pool).createIdleResources.func1()
/go/pkg/mod/github.com/jackc/pgx/[email protected]/pgxpool/pool.go:512 +0x3c
created by github.com/jackc/pgx/v4/pgxpool.(*Pool).createIdleResources
/go/pkg/mod/github.com/jackc/pgx/[email protected]/pgxpool/pool.go:510 +0xa5
I think somehow the puddle is nil but I couldn't find anywhere in the code that could be setting the puddle to nil
from pgx.
jackc
commented on September 10, 2024
That's not a pgx panic. It is the DialFunc that you have configured panicking.
from pgx.
madisonchamberlain
commented on September 10, 2024
Oh my bad thank you!
from pgx.
Related Issues (20)
- Add `Close()` method to the connector for a pooled connection HOT 3
- chunkreader Next returns internal/poll.DeadlineExceededError when returning a column with some Kb data. HOT 3
- pgxpool: different MaxConnLifetime for fallback hosts HOT 1
- The type for "MONEY" isn't detected
- Support directly inserting pgtype.Bits into a column of type BIT(n) using named args
- Discussion: useful to return rows early using iter.Seq? HOT 2
- Discussion: Improve pgx.CollectRows to dynamically allocate sufficient slice capacity to avoid memory reallocations HOT 2
- pgtype.ArrayCodec should support non-comma delimiter HOT 2
- `fatal error: concurrent map writes` in `EnumCodec.lookupAndCacheString` HOT 4
- Support for require_auth configuration parameter HOT 1
- Security: Uncaught Exception Violation found by Snyk HOT 3
- RowToStructByName, Lax and Pos not working with `db:"-"` tag HOT 1
- Examples or documentation for "WHERE field IN $1" - should be "WHERE field IN ($1)" HOT 1
- Tracelog truncation can make output longer.
- dangling transactions after 'failed to deallocate cached statement' errors HOT 1
- Clarify ErrIsClosed return type in docs HOT 1
- v4.18.3 Security vulnerability CVE-2024-27289 HOT 2
- Running lib/pq and pgx in the same code base? HOT 1
- Cannot scan/insert user defined UUIDs.
- Memory Leak doing INSERT on High-Load service HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgx.