Comments (6)
I'll take a look this weekend, but this is almost certainly related to 414e21e.
from fullserializer.
What does the CanProcess
function look like?
If it looks like typeof(BaseNode) == type
, can you try changing it to return typeof(BaseNode).IsAssignableFrom(type)
instead?
I made a change so that processors are resolved based on the actual instance type instead of the type passed in - still thinking about the proper behavior. I may revert it to be based on the declared deserialization type and not the instance type.
from fullserializer.
Also, is OnBeforeDeserialize
getting called?
from fullserializer.
Hey Jacob,
Thanks for taking a look into it.
Sorry. I forgot to mention it initialy, but OnBeforeDeserialize
is called normaly yes. That's the most weird part actually.
CanProcess is also "declared" like typeof(BaseNode).IsAssignableFrom(type)
.
Right after OnBeforeDeserialize
is called, the error "Cannot create an instance of an interface or abstract type for BaseNode" is thrown, which is normaly the case when the serialized $type is missing. That's what I am trying to handle in OnBeforeDeserialize
by altering the serialized information.
This used to work a couple of version back. I can't really say why it doesn't now :)
If you need more information, please let me know.
Thanks a lot!
from fullserializer.
I believe the given commit should fix the issue. Let me know.
from fullserializer.
Hey Jacob,
Everything works fine again with the latest commit.
Thanks a lot!
from fullserializer.
Related Issues (20)
- Infinite loop when parsing "/2/" HOT 1
- Unity 2018 with .NET 4.X compatibility on AOT platforms crashes on fsMetaProperty.Read
- Keyframe-related Deprecation Warnings in Unity 2018 HOT 3
- Cannot deserialize dictionary of <string, int>
- No closing } for object; context = <{>for valid JSON when using fsJsonPrinter.PrettyJson HOT 1
- FormerlySerializedAs is not respected when parsing arrays
- Should Deserialization be clearing the cyclic reference manager as well? HOT 2
- Deserialize doesn't override the whole array HOT 1
- How to build this dll?
- [Question] Update serialized property name
- The type or namespace name 'ExpectedException' could not be found HOT 2
- "MonoBehaviour using the 'new' keyword. This is not allowed."
- Incorrect type is used for Processors in Deserialize Version flow.
- Is there any way of disabling $content and $type fields from generating when I am serialising generic object
- Json generate $ref, $id and $content automatically, how do skip this?
- Multithreaded Lock during deserialization - (describes fix)
- StackOverFlow HOT 1
- Migration system doesn't work with objects inside parent container HOT 1
- Custom deserialization of null values
- Just a warning to fix
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fullserializer.