Giter VIP home page Giter VIP logo

Comments (4)

jacobobryant avatar jacobobryant commented on August 20, 2024

I've recently added google SSO to Findka. I haven't moved any of that code into Biff, but I will at some point. If anyone wants to use google SSO now/soon, I can prioritize that (or at least post some code samples--it wasn't very complicated).

My implementation of google SSO is a little unorthodox. I don't use google's JWT for session management; I just use it once to verify that you control a given email address, and then I authenticate your (cookie-based) session for that address. This made development fast since Biff already manages the sessions for signin-via-email-link. I didn't want to overhaul Biff's logic for checking authentication. Eventually it'd be worth re-evaluating if using (encrypted, stateless) session cookies is a good approach or if we should switch to JWTs.

from biff.

jacobobryant avatar jacobobryant commented on August 20, 2024

Also it would be better if email link auth included a temporary code the user can enter in, in case you open the email on a different device from the one you're trying to log in with. That can also help users get around those (stupid, despicable) embedded web browsers that mobile apps are so fond of using.

from biff.

jacobobryant avatar jacobobryant commented on August 20, 2024

New version of Biff is a lot simpler, and I think just doing email link authentication in the starter project makes sense. The authentication code is very easy to change (it's all contained in the template code). If anyone wants passwords/sso they can implement it themselves and blog about it, then we could link to the blog post from the biff docs.

from biff.

jacobobryant avatar jacobobryant commented on August 20, 2024

Also it would be better if email link auth included a temporary code the user can enter in, in case you open the email on a different device from the one you're trying to log in with. That can also help users get around those (stupid, despicable) embedded web browsers that mobile apps are so fond of using.

this would still be nice. Notion's implementation makes a good reference. But for now I'll leave this closed until someone brings it up.

from biff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.