Giter VIP home page Giter VIP logo

Comments (59)

PatrzKomuUfaszGb avatar PatrzKomuUfaszGb commented on May 28, 2024

I had exactly same problem. Use magisk module and select yes two times in installation screen= Two times volume up.

from gappsmod.

xaras2 avatar xaras2 commented on May 28, 2024

I had exactly same problem. Use magisk module and select yes two times in installation screen= Two times volume up.

Thx but not working for me, some issue :/

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Unfortunately I cannot replicate your bug.

Does it happen with the latest GoogleDialerMod v1.06 too?

Could you please start the Dialer from ADB in debug mode, using the adb shell "am start -D com.google.android.dialer" command, and send me the logcat captured during the failed recording?

Thanks.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

Yes in my pixel 7 pro it is the same, also in 1.0.6

Unfortunately I cannot replicate your bug.

Does it happen with the latest GoogleDialerMod v1.06 too?

Could you please start the Dialer from ADB in debug mode, using the adb shell -c 'am start -D com.google.android.dialer' command, and send me the logcat captured during the failed recording?

Thanks.

Yes in my pixel 7 pro it is the same, also in 1.0.6
and about the debug it sais adb shell: unknown option -- c

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

About the debug it sais adb shell: unknown option -- c

You probably typed adb shell --c 'am start -D instead of adb shell -c 'am start -D

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

adb shell -c 'am start -D com.google.android.dialer'

nope

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

nope

Sorry, my bad. The correct command is adb shell "am start -D com.google.android.dialer".

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

nope

Sorry, my bad. The correct command is adb shell "am start -D com.google.android.dialer".

Ok I did that, where is the logs?

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Ok I did that, where is the logs?

Steps to collect logs:

  1. Force close the dialer
  2. Move the terminal to the folder of your choice using the cd command (e.g. cd %userprofile%\desktop to later save log files on your desktop)
  3. adb shell "am start -D com.google.android.dialer"
  4. adb logcat > logs.txt
  5. Make a call, try to record, obtain the error message, end the call
  6. CTRL+C to stop the logs collection
  7. Upload here logs.txt

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@jacopotediosi

here you go

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

@shlomi10 Can you please confirm that call recording doesn't work even with the "Silence call recording alerts" switch turned off?

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@shlomi10 Can you please confirm that call recording doesn't work even with the "Silence call recording alerts" switch turned off?

yes, they were and they are on OFF

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

yes, they were and they are on OFF

Sadly, that means this is a Google Dialer bug, which fails to play the Call Recording disclosure announcement (his original audio file, which he generated itself) on your device.
I don't know if I'll be able to fix it, because it should be Google's job to make sure its piece of code works.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

But the recording is failed thurgh the call, and I don't want the sound (the small bips while recording) so there is still what to play?
And in the other hand how there is no bug on this at Google side?

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

How there is no bug on this at Google side?

There is: https://support.google.com/phoneapp/thread/123105349/call-recording-not-working?hl=en

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

from gappsmod.

bagarwa avatar bagarwa commented on May 28, 2024

Fwiw, I've also started getting this "Recording Failed" error. The first time I had tried the record option, it had worked. But there after, every time I tried, I got this error.

Pixel 7 Pro, running Android 13 QPR1 Beta 3, Magisk Canary 25205. Google Dialer Mod 1.06

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Fwiw, I've also started getting this "Recording Failed" error

Could you please also confirm that the problem occurs with the "Silence call recording alerts" switch turned off?
Thanks

from gappsmod.

bagarwa avatar bagarwa commented on May 28, 2024

Could you please also confirm that the problem occurs with the "Silence call recording alerts" switch turned off? Thanks

In my case, the issue is now occurring only when "Silence call recording alerts" switch is turned on. With it off, the recording is working. But I do want to keep it on.

from gappsmod.

kartikbillimoria avatar kartikbillimoria commented on May 28, 2024

Could you please also confirm that the problem occurs with the "Silence call recording alerts" switch turned off? Thanks

In my case, the issue is now occurring only when "Silence call recording alerts" switch is turned on. With it off, the recording is working. But I do want to keep it on.

I have the same issue on my Pixel 4XL with the latest beta version of the dialer app.

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Hi @bagarwa and @kartikbillimoria,

Could you please try this test version I just created?

You have to turn on the "Silence call recording alerts" switch and force close and reopen the Google Dialer a couple of times.
Then, try to record a call and please check if the "Recording Error" error still appears.

Thanks!

from gappsmod.

kartikbillimoria avatar kartikbillimoria commented on May 28, 2024

Thanks a lot for the test version but unfortunately it didn't work. I'll reply the same on Github. Getting the same message.

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Thanks a lot for the test version but unfortunately it didn't work. I'll reply the same on Github. Getting the same message.

With the switch turned off instead it works (and you hear the "this call is now being recorded" audio)?

from gappsmod.

kartikbillimoria avatar kartikbillimoria commented on May 28, 2024

from gappsmod.

bagarwa avatar bagarwa commented on May 28, 2024

Confirming the same as Kartik.

from gappsmod.

Kingistador avatar Kingistador commented on May 28, 2024

Can confirm, it's not working with silencing, so i'm just using auto recording switch, and for silencing i'm using TTSLexx.

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Can confirm, it's not working with silencing, so i'm just using auto recording switch, and for silencing i'm using TTSLexx.

Can you share the content of your /data/data/com.google.android.dialer/callrecordingprompt folder when using TTSLexx?

from gappsmod.

p1580 avatar p1580 commented on May 28, 2024

Can't auto record and Silence call recording alerts doesn't work too Google dialer is newest
test ver can't same
GT NEO 3 RMX3561_11_C.15

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

Can't auto record and Silence call recording alerts doesn't work too Google dialer is newest GT NEO 3 RMX3561_11_C.15

"Can't" and "doesn't work" aren't very helpful to identify and fix bugs. Please better describe what's happening, error messages, provide logs, etc. This is always a good reference: http://www.catb.org/~esr/faqs/smart-questions.html

from gappsmod.

p1580 avatar p1580 commented on May 28, 2024

Sorry. When I open Force enable call recording and Silence call recoding alerts both aren't work.
I must manual press recond button. Before I update my system is work fine.
Did i need give you log or something? Thanks turely

Update:Now It's work fine. I turn Google dialer to factory version 90.0.477356402
The newest ver 95.0.491468435 seems like not work call recording and Silence call recoding

Update: The newest ver 95.0.491468435 is work for me now. I good I use test ver.

from gappsmod.

Kingistador avatar Kingistador commented on May 28, 2024

Can you share the content of your /data/data/com.google.android.dialer/callrecordingprompt folder when using TTSLexx?

Sorry that it took me so long to reply, I had to root my phone again to extract files. Here are they: drive-download-20230109T101651Z-001.zip

And as I can see, your app is adding US files to this folder, when I'm enabling silence toggle, but I have a different country. So maybe this is the problem, the dialer is looking for localized files and recreates them, when the folder is empty.

And by the way, after some time, my phone by itself showed me a message that auto recording is disabled, because it's not supported in my country. Maybe after an auto update by play store or because i was messing with gps mocking in developer settings, i don't remember. I had to re-enable the flag.

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

the dialer is looking for localized files

No, the "silence call recording alerts" flag forces the dialer to use US files and replace them with an empty audio

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

@shlomi10
Change the system language to English.
I had the same problem as you described, try changing the system language to English, force stop the dialer and reopen it and it should work.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@shlomi10 Change the system language to English. I had the same problem as you described, try changing the system language to English, force stop the dialer and reopen it and it should work.

yes you right, it worked but after call ended I didn't find it on Recordings folder, so that is intereset, and niw @jacopotediosi got one solution I guess

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

@shlomi10 which was your language?

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@jacopotediosi Hebrew

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

@jacopotediosi
Hebrew here too.

@shlomi10
I think there is no recording folder. Anyway, I have access to the recordings through the dialer and it works fine when the language is English.
Any attempt to change the language back to Hebrew will lead to a recording error.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

I have access to this too, but I don't see the recordings, just the option to remove them, anyhow its interest where is the folder of it

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

The folder is in /data/data/com.google.android.dialer/files/callrecording (#41).

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

yes it's there, interest , so now the idea is that it will work in all languages

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

The discovery about the Hebrew/English language is very interesting. It may be that setting the language to Hebrew cause the call recording announcement audio file to become corrupted and the recording to fail.

Unfortunately the latest Dialer versions rewrite that audio at the beginning of each recording (#50), so there is currently no way to replace it with a working one.

This whole project is a nightmare :(

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

But I didn't set the settings for annnounce that it's record something

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

But I didn't set the settings for annnounce that it's record something

No options for it. Dialer forces that audio to play every time a recording is started.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

So the switch to not announce the recording (Silence call record) is not actualy working?
And also maybe it's better to revert to older version?

from gappsmod.

Kingistador avatar Kingistador commented on May 28, 2024

Unfortunately the latest Dialer versions rewrite that audio at the beginning of each recording (#50), so there is currently no way to replace it with a working one.

I'm a little bit out of topic, but I think the dialer on my phone has been auto updated, and it's getting very weird. I'm still using TTSLexx for silencing warnings and now when I call somebody, I hear that warning in the beginning, but it's much quieter, and the person on the other side doesn't hear it at all. But if somebody calls me, then there is no warning even for me...
And recording still works fine.

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

@jacopotediosi
Why can't I find this folder in /data/data/com.google.android.dialer/files/callrecording?

Regarding the Hebrew - I know it from my use of a Xiaomi device. The device came with the Google dialer by default. The recording option did not appear in the Hebrew language. Changing the language to English made it possible to record and left the option even after returning the device language to Hebrew. Which does not happen in this case. And in Xiaomi it was without root and installing one or another mod.

@shlomi10
Something more interesting - I removed the Google dialer updates. I did the steps I described earlier, changed the language back to Hebrew, and the recordings still work.
I can't say if it will work for you too because I played with a few things that might have caused it but it's worth a try.
The "silence call recording alerts" flag is off for me and despite this, "this call is now being recorded" audio is not played.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

In google dialer at my pixel 7 pro there is no updates :)

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@jacopotediosi
It's interest because if it's something of the dialer itself then we can change the Dialer app language only (something we can't do in google settings by the way), but if it's something of the system then whats inside the system?
Anyhow you have any solution?

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

@jacopotediosi
Regarding what is written here:
#50 (comment)

For reference: latest Google Dialer version in which we can silence call recording announcement is https://www.apkmirror.com/apk/google-inc/google-phone/google-phone-94-0-490096008-release/.

Does this mean that the latest version of Google Dialer that I can use without changing the device language to English is the version you linked to?

Any more recent version will actually try to replace the files with each recording and lead to an error? (because there are no such files in the Hebrew language apparently).

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

@jacopotediosi Regarding what is written here: #50 (comment)

For reference: latest Google Dialer version in which we can silence call recording announcement is https://www.apkmirror.com/apk/google-inc/google-phone/google-phone-94-0-490096008-release/.

Does this mean that the latest version of Google Dialer that I can use without changing the device language to English is the version you linked to?

Any more recent version will actually try to replace the files with each recording and lead to an error? (because there are no such files in the Hebrew language apparently).

Probably. I'll have to test it.

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

This ticket remains open just for the Hebrew thing.
Currently, the only other known cause for "recording failed" error we could do something for is the dialer not installed as system app (currently managed in a separate #46 issue).

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

actualy I have the latest dialer form google, and the recorder from here and it worked with hebrew - yesterday I tested it

from gappsmod.

jacopotediosi avatar jacopotediosi commented on May 28, 2024

actualy I have the latest dialer form google, and the recorder from here and it worked with hebrew - yesterday I tested it

@NirAsulin can you please test if the bug still happens with the latest version of the Dialer?
Thanks.

Otherwise I'll close this thread, because the problem seems to be solved for everyone involved.

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

actualy I have the latest dialer form google, and the recorder from here and it worked with hebrew - yesterday I tested it

Is "this call is now being recorded" audio played in recordings?
Can you detail when and how the problem was solved for you? I remember that in the previous versions the recordings did not work for you.

@NirAsulin can you please test if the bug still happens with the latest version of the Dialer? Thanks.

Otherwise I'll close this thread, because the problem seems to be solved for everyone involved.

@jacopotediosi I will definitely check it out in the next few days and update, thank you.

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@NirAsulin the "this call is now being recorded" is just played to your side, but when you play the recordings you won't hear it.

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

@shlomi10 But does the other side hear the message at the start of the recording?

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@shlomi10 But does the other side hear the message at the start of the recording?

I need to test it, can you too?
Thanks

from gappsmod.

NirAsulin avatar NirAsulin commented on May 28, 2024

can you please test if the bug still happens with the latest version of the Dialer?
Thanks.

@jacopotediosi
I apologize for the delay, there were some technical issues.
The device has been updated to version TQ2A.230505.002, as well as Magisk 26.1 and GoogleDialerMod version 3.00.
Google Dialer version 105.0.529096231-publicbeta.

As I described a few months ago - when the device is on the English language, everything works fine.
Any attempt to change the language back to Hebrew will lead to a recording error.

editing:

It's a little more complex:
At first the recording did not work in Hebrew.
After changing to English, making a recording and returning the language to Hebrew it seems that the recordings still work.
If I "force stop" the dialer and then reopen it, an attempt to record encounters an error.

I need to test it, can you too?
Thanks

@shlomi10
Is there anything new about this?
If the recording still works for you in the Hebrew language, could you tell me what version of Google Dialer you have?

from gappsmod.

shlomi10 avatar shlomi10 commented on May 28, 2024

@NirAsulin still works
104.0.527367108-pixel2022

from gappsmod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.