Comments (4)
Synchronous pushes threading model to the caller who's often on a BG thread already (e.g., making an HTTP call). Complex entries are needed as your parameterized API offers no explanation of how complex key value types are serialized. And finally, this is not an Android library so it cannot know about getCacheDir().
Either write a high-level wrapper or use another library. These changes will not be made.
from disklrucache.
Ok, getCacheDir() is not needed.
But complex entries is not needed - just allow caller to supply serializer to/from byte[].
This is not android library, but most usages for such cache is on the android, because servers use Redis/Memcache and other distributed services for caching and your solution is not scalable.
from disklrucache.
I shipped something similar in a different library and it was a terrible
decision for something at this level. I will not be adding it here so you
are welcome to try your ideas in a fork or a separate library.
On Sat, May 2, 2015, 2:22 PM Virl [email protected] wrote:
Ok, getCacheDir() is not needed.
But complex entries is not needed - just allow caller to supply serializer
to/from byte[].This is not android library, but most usages for such cache is on the
android, because servers use Redis/Memcache and other distributed services
for caching and your solution is not scalable.—
Reply to this email directly or view it on GitHub
#80 (comment)
.
from disklrucache.
Thanks, I'm already thinking about making my small library for android disk cache. Maybe if it will be finished, I will post it to github.
Btw, look at your forks: most of them are fixes for Android. There is even separate wrapper library called Reservoir (but unusable due to poor design).
from disklrucache.
Related Issues (20)
- Clear Cache HOT 1
- Copyright (C) 2011 The Android Open Source Project Copyright 2012 Jake Wharton Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- executorService is not shut down
- Can you support the OpenHarmony JavaScript version? HOT 1
- Does getCacheDir() supported? HOT 3
- Multi-thread: Infinite loop in trimToSize HOT 5
- Closing the correct resource ? HOT 1
- Validate key Issue HOT 1
- max size doesn't take in consideration minimum 4kb block size. HOT 2
- Files disappear after a while HOT 1
- Old Image is always shown HOT 1
- Basic usage and code samples? HOT 1
- [Question] Where is the performence report of DiskLruCache? HOT 1
- what can cause cache is closed
- Hey! 61 tests 10 failed I have... HOT 5
- Request for new release 2.0.3 HOT 1
- Get entry count/iterator
- while loop in StrictLineReader.java HOT 2
- Key length is 64 for dependencies resolved via maven/jcenter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from disklrucache.