Giter VIP home page Giter VIP logo

Comments (4)

JakeWharton avatar JakeWharton commented on July 3, 2024

Synchronous pushes threading model to the caller who's often on a BG thread already (e.g., making an HTTP call). Complex entries are needed as your parameterized API offers no explanation of how complex key value types are serialized. And finally, this is not an Android library so it cannot know about getCacheDir().

Either write a high-level wrapper or use another library. These changes will not be made.

from disklrucache.

virl avatar virl commented on July 3, 2024

Ok, getCacheDir() is not needed.

But complex entries is not needed - just allow caller to supply serializer to/from byte[].

This is not android library, but most usages for such cache is on the android, because servers use Redis/Memcache and other distributed services for caching and your solution is not scalable.

from disklrucache.

JakeWharton avatar JakeWharton commented on July 3, 2024

I shipped something similar in a different library and it was a terrible
decision for something at this level. I will not be adding it here so you
are welcome to try your ideas in a fork or a separate library.

On Sat, May 2, 2015, 2:22 PM Virl [email protected] wrote:

Ok, getCacheDir() is not needed.

But complex entries is not needed - just allow caller to supply serializer
to/from byte[].

This is not android library, but most usages for such cache is on the
android, because servers use Redis/Memcache and other distributed services
for caching and your solution is not scalable.


Reply to this email directly or view it on GitHub
#80 (comment)
.

from disklrucache.

virl avatar virl commented on July 3, 2024

Thanks, I'm already thinking about making my small library for android disk cache. Maybe if it will be finished, I will post it to github.

Btw, look at your forks: most of them are fixes for Android. There is even separate wrapper library called Reservoir (but unusable due to poor design).

from disklrucache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.