Describe the bug Double Take cannot connect to MQTT broker with T

Linked to issue <a class="issue-link js-issue-link" data-error-text="Failed to load ti

[BUG] secure-mqtt not enabled when TLS settings are provided about double-take HOT 2 OPEN

poulti commented on May 23, 2024

[BUG] secure-mqtt not enabled when TLS settings are provided

from double-take.

Comments (2)

poulti commented on May 23, 2024

I looked at paho.mqtt.client (python library to connect to mqtt brokers, the one used by Frigate)

A code snippet in the connect_srv method reveals:
In client.py, line 933

        try:
            rr = '_mqtt._tcp.%s' % domain
            if self._ssl:
                # IANA specifies secure-mqtt (not mqtts) for port 8883
                rr = '_secure-mqtt._tcp.%s' % domain

--> The comment suggests that the proper way is to use the protocal name "secure-mqtt" instead of "mqtts".

An idea of fix in mqtt.util.js, line 91+:

const isSecure = MQTT.TLS.KEY || MQTT.TLS.CERT || MQTT.TLS.CA;
const protocol = isSecure ? "secure-mqtt://" : "mqtt://";

CLIENT = mqtt.connect(`${protocol}${MQTT.HOST}`, {
  reconnectPeriod: 10000,
  username: MQTT.USERNAME || MQTT.USER,
  password: MQTT.PASSWORD || MQTT.PASS,
  clientId: MQTT.CLIENT_ID || `double-take-${Math.random().toString(16).substr(2, 8)}`,
  key: MQTT.TLS.KEY ? filesystem.readFileSync(MQTT.TLS.KEY) : null,
  cert: MQTT.TLS.CERT ? filesystem.readFileSync(MQTT.TLS.CERT) : null,
  ca: MQTT.TLS.CA ? filesystem.readFileSync(MQTT.TLS.CA) : null,
  rejectUnauthorized: MQTT.TLS.REJECT_UNAUTHORIZED === true,
});