Comments (4)
I confirm this. I believe the problem relies on the fact that the search and replace code in the plugin uses the file path in the search expression. If you are on Windows, this means "css\style.css", which will fail because the HTML has "css/style.css".
I've temporarily fixed this just adding .replace(path.separator,'/') to line 8 to normalize the separator, but this assumes that no one will be using windows-style paths o their html urls (it's a fair assumption, I believe).
@jamesknelson I will create a pull request, however I'm not sure if this is the best possible fix (I'm just starting with NodeJS / Gulp). Feel free to ignore the pull if there is a better solution.
from gulp-rev-replace.
+1
from gulp-rev-replace.
👍
from gulp-rev-replace.
Can somebody confirm for me that merging #5 has fixed this? I'd happily merge a test for it as well...
from gulp-rev-replace.
Related Issues (20)
- Index replacements fail to occur when using gulp-filter HOT 1
- is it me, or this doesn't work with gulp-filter? HOT 1
- Can only be replaced once ?
- Not working on php files ? HOT 1
- Replacing CSS and JS references in PHP files with this 'assets' task?
- working with html.twig (php templates) file HOT 1
- Confused as to the usage of this plugin in regards to new filepaths
- Question: How to use gulp-rev & gulp-rev-replace with custom src that does not match file name
- could i use gulp-rev setting the url in the rev-manifest.json
- fail to work with [email protected] HOT 2
- Html Output Doesn't Contain Replaced Names If Using $.rev.manifest() HOT 2
- Not making replacements in src files without replaceInExtensions
- options.replaceInExtensions HOT 12
- No replace in json files HOT 4
- should provide the file information to `modifyUnreved/modifyReved` method?
- replacing same reference more then one times HOT 1
- the plugin can't replace requirejs path in php file HOT 2
- Can't replace URI-encoded file name including non-ascii characters HOT 1
- Replace deprecated dependency gulp-util
- .woff2 references inside css not renaming correctly HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-rev-replace.