Giter VIP home page Giter VIP logo

Comments (4)

sesponda avatar sesponda commented on September 25, 2024

I confirm this. I believe the problem relies on the fact that the search and replace code in the plugin uses the file path in the search expression. If you are on Windows, this means "css\style.css", which will fail because the HTML has "css/style.css".

I've temporarily fixed this just adding .replace(path.separator,'/') to line 8 to normalize the separator, but this assumes that no one will be using windows-style paths o their html urls (it's a fair assumption, I believe).

@jamesknelson I will create a pull request, however I'm not sure if this is the best possible fix (I'm just starting with NodeJS / Gulp). Feel free to ignore the pull if there is a better solution.

from gulp-rev-replace.

yuri-karadzhov avatar yuri-karadzhov commented on September 25, 2024

+1

from gulp-rev-replace.

kasperisager avatar kasperisager commented on September 25, 2024

👍

from gulp-rev-replace.

jamesknelson avatar jamesknelson commented on September 25, 2024

Can somebody confirm for me that merging #5 has fixed this? I'd happily merge a test for it as well...

from gulp-rev-replace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.