"tell me a..." broken horribly? about bmotion HOT 6 CLOSED

I've just installed this and I can confirm this behavior:

<Routh> Darkwolf tell me a joke
<DarkWolf> Routh: 3168.

from bmotion.

Horrible brokeness in complex_randomnumber.tcl by the looks of it:

• matches too readily (i.e. on things not saying "...a number" at the end
• needs to handle punctuation better

The 2nd one is probably addressed somewhere else in the code - I recall writing some stuff (maybe for complex_questions.tcl) to make it 'standardise' the punctuation around the bot's nick at the start of a line so that the plugin only had to match on one form (e.g. botnick:)

from bmotion.

Hmm it would be good if the bot was able to recognize several forms, based on how people type naturally. My bot is on a private IRC network I run for my writing site so people use various punctuations..

botnick: <command>
botnick, <command>
botnick... <command>

Your theory about not having the bot respond when it shouldn't is good, but I think this should only apply to alphanumeric modifiers and not punctuation modifiers.. for example:

No response

botnicksuffix
prefixbotnick
123botnick

Response

 "botnick"
 botnick:
 ....botnick

from bmotion.

That's how pretty much every other plugin responds, it's just this one which is broken :)

For 123botnick there's a setting in settings.tcl which determines if it wraps it's nick with regexp begin-word and end-word markers (on by default)

from bmotion.

Hmm, noticed you closed this and made a commit. I pull the latest, restarted/rehashed. Now the bot will not respond to any of the "tell me a..." commands at all.. responds in other ways still.

from bmotion.

That's because the only one it's supposed to respond to is "tell me a number", the others don't exist :)

from bmotion.