MIgration of exiting Table to Hypertable not working about django-timescaledb HOT 8 CLOSED

Also the TimescaleSchemaEditor extends PostGISSchemaEditor instead of django.db.backends.postgresql.schema.DatabaseSchemaEditor.

Should this be fixed?

https://github.com/schlunsen/django-timescaledb/blob/41c7ac2d70d7738c3012389540e1e11fab6391c5/timescale/db/backends/postgresql/schema.py#L1-L6

from django-timescaledb.

I think we can handle "migration to hypertable" properly (autodetected by the migration framework).

• For new table - the current implementation works
• For existing table - there are two cases
  • new "time" field added and use it as partition column
    • migration autodetect feature - will create AddField migration operation
    • which internally calls schema_editor.add_field(from_model, field)
    • we override this method and call super.add_field(from_model, field)
    • then we check if new field is type TimeScaleDateTimeField
    • if that is true we trigger "migrate_to_hypertabe" - procedure for it defined below
  • use "existing datetime" field as partition column
    • migration autdetect feature - will create AlterField migration operation
    • which internally calls schema_editor.alter_field(from_model, from_field, to_field)
    • we override this method and call schema_editor.alter_field(from_model, from_field, to_field)
    • we check if the "type" has changed
    • if that is ture, we trigger "migrate_to_hyertable" procedure

"migrate_to_hypertable" producre

There are two way we can do this:

1. [#16] create new hypertable "like" the old one - insert all rows from old to new; this is what is recommened here
   • this one is recommended as it does not lock the old table, good for large table
   • one issue here is - deleting old(non-hyper)table
     • should this be done automatically - risking data lose? (if implmented correctly wont happen, but cant say!)
     • or we let it be and tell user to "drop" it when he thinks the migration was perfect
2. create hypertable "with" existing table - with migrate_data => true option when calling create_hypertable; as described here
   • this is relatively simpler to implement and safe (as timescaledb takes the responsibility for "migration")
   • as mentioned in the docs (check below) - this could lock the table and this could be an issue for large tables

     WARNING:The use of the migrate_data argument to convert a non-empty table can lock the table for a significant amount of time, depending on how much data is in the table. It can also run into deadlock if foreign key constraints exist to other tables.

from django-timescaledb.

Am I doing anything wrong?

from django-timescaledb.

@schlunsen let me know your views, so that I can start working on it?

Do we have test framework(I am new to automatic testing)? so that we can check various conditions for migrations ?

from django-timescaledb.

Hi @daadu

Thanks for taking the time to look into this, really nice with some movement on this project! I really appreciate that you have documented and highlighted the issues regarding the migration so well.

Would be awesome to have migrations working, which as you correctly observed isn't the case at the moment.

I think both use cases are valid and it could be nice if the we with relatively ease could change the strategy of the migration. Maybe this could be a configurable setting for the migration?

I lean mostly towards having option 2 that you mention as a default and using migrate_data => true when creating the hypertable.

from django-timescaledb.

Hi @daadu,

Really cool input on this! Looks like a really positive change. As for testing I would recommend we use pytest and the standard Django test framework and use a GitHub actions to setup as a CI. I agree with @schlunsen that option 2 is the best option, my use cases are only greenfield, does the migrate_data => true have any impact on new tables or is that ignored by timescale? I can't see anything in the docs.

from django-timescaledb.

@bencleary for new table (create_model call in schema), the migration passes migrate_data => false, so does not affect that.

from django-timescaledb.

@bencleary Looks like you have self-assigned #1 , have begin the work for it? where can I check it. would love to add to for migrations.

from django-timescaledb.