Giter VIP home page Giter VIP logo

Comments (4)

jamesssooi avatar jamesssooi commented on May 31, 2024 1

For Croppr to work on scaled images, the proper way is to resize all its img tags and not the div tags. For instance:

.croppr img {
  width: 500px;
}

But I understand that it does seem like a hacky, undocumented way to get it to work. I suppose a simple fix would be for Croppr to simply retain existing styling and class names of the img tag after initialising (it currently does not).

EDIT:
With the latest commit 4ff4d92, Croppr would now simply obey the size of its parent containers. So the above method is outdated, and all you need to do now is to just set the size of its enclosing element.

from croppr.js.

sahandnayebaziz avatar sahandnayebaziz commented on May 31, 2024

p.s. I tried changing the CSS of one of Croppr's divs, but was unsure how to "refresh" Croppr, so to speak, to let it know that the container size has changed. Not sure if that's how you'd recommend it to happen, anyway :)

from croppr.js.

sahandnayebaziz avatar sahandnayebaziz commented on May 31, 2024

A faster way to replicate the situation I'm talking about is by changing the unsplash line in index.html to something like...

<img src="https://unsplash.it/2000/2000/?random" alt="" id="cropper">

Does handling images that are big (like images users upload for profile pictures, for example) seem feasible to you, or potentially out of scope?

from croppr.js.

sahandnayebaziz avatar sahandnayebaziz commented on May 31, 2024

I see. I'll try this! Another way to deal with this, that I came to yesterday, was to resize the image first. I've added a bit more code to handle that part, which is fine, but I do feel like cropping images straight from a users filesystem that might already be very large might be a common use case.

I'll leave it to you to think about. Not sure where to go with it next. Thank you @jamesssooi :)

from croppr.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.