Giter VIP home page Giter VIP logo

Comments (2)

Samuel-Therrien-Beslogic avatar Samuel-Therrien-Beslogic commented on May 22, 2024

For now I disable this config in component files:

    {
      files: ["*.component.ts"],
      rules: {
        // Factories (including lifecycles) should be named functions
        "extra-rules/potential-point-free": "warn",
        "prefer-arrow/prefer-arrow-functions": [
          "error",
          {
            ...preferArrowFunctionsConfig,
            "singleReturnOnly": true,
          },
        ],
      },
    },

from eslint-plugin-prefer-arrow-functions.

JamieMason avatar JamieMason commented on May 22, 2024

Hi @michaeljota @Samuel-Beslogic,
This should be possible by modifying isSafeTransformation to return false if the name matches one of the ones you want to ignore:

const isSafeTransformation = (node) => {
return (
!isGeneratorFunction(node) &&
!containsThis(node) &&
!containsSuper(node) &&
!containsArguments(node) &&
!containsNewDotTarget(node) &&
(!isPrototypeAssignment(node) || disallowPrototype) &&
(!singleReturnOnly ||
(returnsImmediately(node) && !isNamedDefaultExport(node)))
);
};

There is a `getFunctionName function

const getFunctionName = (node) =>
node && node.id && node.id.name ? node.id.name : '';

Adding a new option of names to ignore gets read here

const options = context.options[0] || {};
const getOption = (name) =>
typeof options[name] !== 'undefined'
? options[name]
: DEFAULT_OPTIONS[name];
const singleReturnOnly = getOption('singleReturnOnly');
const classPropertiesAllowed = getOption('classPropertiesAllowed');
const disallowPrototype = getOption('disallowPrototype');
const returnStyle = getOption('returnStyle');

And the new value will also want adding the ESLint's schema

schema: [
{
additionalProperties: false,
properties: {
classPropertiesAllowed: { type: 'boolean' },
disallowPrototype: { type: 'boolean' },
returnStyle: {
default: DEFAULT_OPTIONS.returnStyle,
pattern: '^(explicit|implicit|unchanged)$',
type: 'string',
},
singleReturnOnly: { type: 'boolean' },
},
type: 'object',
},
],

Thanks a lot.

from eslint-plugin-prefer-arrow-functions.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.