Possible memory leak? about fromcss HOT 6 OPEN

I think it could be for two reasons.

1. Plugin works laggy with text nodes. This is most likely due to the fact that you have one extra loop inside loadFonts(selection). This can be fixed by changing to loadFonts(node), and removing loop through selection from the function.
2. figma.loadFontAsync() inside a loop. It would be better to use Promise.all()

However, note that loadFontAsync returns a Promise. Even a Promise resolves immediately, it still needs to round-trip to the JavaScript event loop. So you probably shouldn't call loadFontAsync on the same font repeatedly inside a loop.
https://www.figma.com/plugin-docs/api/properties/figma-loadfontasync/#docsNav

from fromcss.

Good point. I believe at least one loop is necessary as it has to loop through all sub node ranges to be able to load in all the different variants as pictured below:

from fromcss.

Hmm yeah as I feared:

• The first outer loop is necessary to apply to more than one text element being selected
• The second inner loop is needed to get the individual text ranges inside

Two suggestions:

• Is there a way to memoize? Maybe _.memoize or some Vue alternative?
• Do we need to go character by character or can we load 0, len instead of i, i+1?

from fromcss.

I may have misspelled my point. I haven't practiced my English for a long time 🙃

About extra loop: I uploaded this fix here https://github.com/jamillazarev/fromCSS/tree/fix-perfomance-of-updating-text-nodes
About caching: Vue has computed properties https://vuejs.org/v2/guide/computed.html

Based on the documentation, figma caches this aspect itself. It seems to me that we should try to wait for all the promises.

from fromcss.

As far as I can see after a little refactoring, everything works fine. However, I noticed other issues...

from fromcss.

After restarting figma, the problem returned... 🤨

from fromcss.