Giter VIP home page Giter VIP logo

Comments (5)

jan-dh avatar jan-dh commented on May 30, 2024

Since tailwind uses REM as a default & it doesn't really impact your tailwind config I'm not really inclined to do so. What would be your arguments for it?

from figma-tailwindcss.

gkatsanos avatar gkatsanos commented on May 30, 2024

most teams who develop design style guides use their own font size specifications and you can override the default tailwind sizes to anything you want.. not sure why you would add the extra effort to convert them, the style guide designer would be responsible to author in the format they prefer right?
would it be an idea to offer a config option that escapes the conversion?

from figma-tailwindcss.

jan-dh avatar jan-dh commented on May 30, 2024

My point was, your design uses pixels in Figma, the plugin sets these to rem values. These end up in a config which you will use in your code. But what's the difference for you in these scenarios?

Scenario 1: your config has:

base: "1.125rem", // 18px
lg: "1.375rem", // 22px
xl: "1.5rem", // 24px
"2xl": "1.875rem", // 30px
"3xl": "2rem", // 32px
"4xl": "2.5rem", // 40px
"5xl": "3.125rem", // 50px
"6xl": "4.375rem" // 70px

In your code you use this, let's say: text-lg

Scenario 2: your config has:

base: "18px",
lg: "22px",
...

In your code you use this still the same: text-lg.

Don't really see why you would want to change the way you write the values in your config since it doesn't affect the code you write in any way?

from figma-tailwindcss.

gkatsanos avatar gkatsanos commented on May 30, 2024

The tailwind config is used by more than one applications - We switched to pixels because some apps had a different font-size base value and we were having inconsistencies...

from figma-tailwindcss.

jan-dh avatar jan-dh commented on May 30, 2024

Hmm, will try to see if I can get this implemented anytime soon.

from figma-tailwindcss.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.