Date archives about indieblocks HOT 6 CLOSED

Added in dd60f1d

from indieblocks.

If these are active and a post is given a name of, e.g., 2020, you'll get a 404 if no posts for that year are found, rather than the single post with that slug.

I.e., we have to prevent notes/likes get a 4-digit number as a slug. WordPress already does this for pages, or, depending on your permalink setup, for posts, by adding a -2 suffix.

We should probably do the same, i.e., either always add -2 or do it only when there's a chance of conflicting slugs.

from indieblocks.

[O]nly when there's a chance of conflicting slugs.

So not when autogenerated slugs are active, and---possibly, although this could be challenged---also not when actual date-based permalinks are an option, and selected. The issue with not doing it for the latter scenario is that a conflict may still occur once the permalink option is changed.

from indieblocks.

In WP core, what happens is the -2 only gets added when there's potential for a conflict. If afterward the permalink settings are changed, the (now conflicting) single post comes out on top. There's then no way to reach the archive for that year anymore.

We should probably mimic this behavior.

from indieblocks.

See https://github.com/WordPress/wordpress-develop/blob/ec91ec56be44d8cdbc611758b9721860aae60491/src/wp-includes/post.php#L5049 and following.

from indieblocks.

Added in 50fd2b0, although archives take precedence over single posts, should there be a slug conflict. Think I like it that way, so that month and day archives don't all get hijacked by a single post.

from indieblocks.