Giter VIP home page Giter VIP logo

Comments (6)

psprint avatar psprint commented on August 17, 2024 1

I think that it should be in ~/.zgen.

from zgenom.

psprint avatar psprint commented on August 17, 2024

Thanks for interest in implementing the standard. The answers to your questions:

  • $ZERO – it allows to have the options posix_argzero or function_argzero set,
  • $ZPFX – the plugin might still test for the parameter in it's body, plus implementing it is very easy,
  • *_unload – yes, so it might not implement this feature; however implementing a zgen unload … call would be a nice addition to zgen and it would allow to unload e.g.: agkozak theme (it implements the unload function).

from zgenom.

jandamm avatar jandamm commented on August 17, 2024

Would the ZPFX be a prefix somewhere in the filesystem or would it be in the realm of zgenom?
Because the former would have to be OS specific.

from zgenom.

jandamm avatar jandamm commented on August 17, 2024

@psprint I've added most of the zsh plugin standard.

I'm don't like 3. Binaries Directory that much. In my opinion bin is a too common name to automatically add it to the $PATH.
When writing a plugin I'd naturally create a folder bin to store all internal executables and wouldn't expect the plugin manager to automatically add it to the $PATH.

If the user of zgenom wants this behavior they can choose to do so by adding zgenom bin <repo> to their zsh config.
Maybe I'll add an option to enable rule 3.

Apart from 3. I haven't implemented 4-6 since they don't apply (yet).

from zgenom.

svenXY avatar svenXY commented on August 17, 2024

Just a side note: topgrade (see here: https://github.com/r-darwish/topgrade/blob/547df8d346e8a7689213299f6fbb1d5807988b44/src/steps/zsh.rs#L72) uses the existence of the ZPFX directory to determine if zinit is installed and fails if it isn't.

I already opened a MR there to use some other env var, but also wanted to mention it here. especially, since I wasn't able to understand the reason for setting ZPFX here as well.

from zgenom.

jandamm avatar jandamm commented on August 17, 2024

@svenXY the author of zinit described it here:
https://zplugin.readthedocs.io/en/latest/zsh-plugin-standard/#446_global_parameter_with_prefix_for_make_configure_etc

While zinit is probably the most popular plugin manager supporting ZPFX it's not an indicator for zinit and was meant to be provided by other plugin managers.

When I implemented the standard (and with it ZPFX) I was under the impression that this pattern was widely used. In the end I think it was only used by the author of zinit and the standard.
But I also don't see a point in removing it.

from zgenom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.