Comments (5)
yminsky
commented on August 21, 2024
Note that you can also write:
List.findi l ~f |> Option.value_exn |> fstWhich greatly reduces the pain of not having the _exn version.
from base.
shepard8
commented on August 21, 2024
I agree, but as I am working with lists I expect a Not_found exception. However I have seen in the roadmap that you plan to replace the Not_found exceptions by more meaningful messages, so maybe I should not worry about that.
from base.
yminsky
commented on August 21, 2024
Indeed, relying on Not_found being thrown is generally considered an anti-pattern.
from base.
shepard8
commented on August 21, 2024
Oh, I wasn't aware of that. Then as you pointed out earlier there is no real need for a findi_exn. Feel free to close this issue. Sorry for the useless noise and thanks for the indications!
from base.
yminsky
commented on August 21, 2024
Lovely. Closed.
from base.
Related Issues (20)
- Unable to build v0.15~preview.125.13+424 HOT 4
- OCaml 5.00 support HOT 1
- int_math_stub.c should use BitScanReverse for clz (and BitScanForward for ctz) HOT 1
- Core.List.exists doesn't work as expected HOT 1
- Support for non-empty lists HOT 4
- Difference between `base`, and `core_kernel`? HOT 2
- Cannot build on system with only ocaml and dune installed. HOT 1
- Please don't auto-register printers for exceptions defined outside of Base HOT 2
- Map.update changes the "physical" key in certain circumstances HOT 1
- What is the policy regarding support for older OCaml versions ? HOT 3
- Base v0.16.0 build failure on windows HOT 2
- make List.take return physical identity for n = length HOT 1
- Linker error on macOS with base 0.16.1 HOT 3
- v0.16.2 is broken with MSVC on Windows HOT 3
- Use `write-file` instead of `bash` in dune action HOT 1
- No docs HOT 2
- Add String.to_sequence (the standard library has String.to_seq)
- Allow for libraries depending on base to enable dune's (implicit_transitive_deps false) HOT 2
- Segmentation fault with `String.filter_map` HOT 3
- Build failure with clang: unsupported `-mpopcnt` option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base.