Power sets are broken for ES6 about js-set-extension HOT 5 CLOSED

hi @michaelmior thank you for the bug report. I will investigate and will use this as a chance to revive this package.

from js-set-extension.

This revealed another bug in Set.prototype.equal, where

Set {
  Set { 1, 2, 3 },
  Set { 1, 2 },
  Set { 1, 3 },
  Set { 2, 3 },
  Set { 1 },
  Set { 2 },
  Set { 3 },
  Set {}
}

and

Set {
  Set { 3 },
  Set { 3, 2 },
  Set { 3, 1 },
  Set { 3, 2, 1 },
  Set {},
  Set { 1 },
  Set { 2 },
  Set { 3 }
}

are evualuated as equal, while in fact they are not.

from js-set-extension.

Another bug is that there should be no doubled entries of Set { 3 }. It is right to assume, that these are two totally different instances and therefore pass the checks but their absolute value representation are the same (Set { 3 } should be considered equal to Set { 3 }). So the Set.prototype.has function is also involved here.

The has function is not involved, as it works correct. The add function is rather affected:

const set = (...args) => new Set(args)

const set1 = set(3)
const set2 = set(3)

const set3 = set()
set3.add(set1)
set3.has(set1) // true
set3.has(set2) // true

set3.add(set2) // should skip set2
set3 // Set { Set { 3 }, Set { 3 } }

from js-set-extension.

@michaelmior I added you as collaborator. If you accept I can assign you to review the PR #51 which attempts to fix the issue.

from js-set-extension.

Implemented, via #51

from js-set-extension.