joss/editing about copro HOT 9 CLOSED

@soodoku I have updated the readme.md (9c702d7) .

Let me know if this clarifies (some of) your questions.

from copro.

additional contextual content in the notebooks was added in ed3fd13

from copro.

1. fix the spellings etc. "employes" -> "employs" by using something like Grammarly
2. it is good to provide some additional details of the models: what are the Xs (what units), how does train/test split happen, how does hyper-param tuning happen, etc. and useful to give baseline results from your core example model, linking to the data.

from copro.

grammarly used to fix typos in paper, docs, and readme in commit 120f1c5 and b279c48

from copro.

the readme.md file was updated in 0936a8a.

it contains now a link to the example data stored on Zenodo. The ROC curve based on the example data (as computed in the notebooks) is shown in the readme.md now.

from copro.

i have put more contextual info and explanations about the models in the notebooks with c458f92.

from copro.

thanks much @JannisHoch. I think it makes the package more usable more quickly. I am going to ping you again as I run my first model.

here's one portion that i am struggling w/ in the JOSS ms:

"CoPro is a novel, fully open, and extensible tool to combine the inter-disciplinary expertise required to make long-term projections of conflict risk associated with climatic and environmental drivers. "

I think that line is a bit vague. What is the precise value copro is providing is really useful to convey and something I have struggled to articulate. My hunch = "it is a python packages that makes it easier to build and validate models of how climate change predicts conflict locally. it makes it easier by providing some pre-packaged models that can work as starting points, some visualization functions, and ...." see if you can finish that and then put it in the paper and the readme.

from copro.

hi @soodoku, i have tried to make it clearer without being to specific on the technical details. see commit a31963e.

from copro.

looks good

from copro.