Comments (4)
@rm3l:
This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue
command.
In response to this:
What do you want to improve?
What is the current documentation?
In the
ServiceMonitor
resource to create, the label name added by the Operator has changed fromjanus-idp.io/app
torhdh.redhat.com/app
a long time ago (janus-idp/operator#199) before the first version of the operator was released, and we forgot to update this doc.Also, the container port endpoint to scrape metrics from seems to be wrong. It should be
backend
as per the1.1.x
,1.2.x
ormain
branches in the operator repo.As a consequence, the instructions depicted in this https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/monitoring-and-logging.md#operator-backed-deployment will not work as expected.
What is the new documentation?
- Replace
janus-idp.io/app
withrhdh.redhat.com/app
- Replace the container port name from
http-backend
tobackend
- Make sure the instructions provided work correctly
/good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
from backstage-showcase.
The relevant updates have been made for this issue and I have also opened up the PR: https://github.com/janus-idp/backstage-showcase/pull/1332.
from backstage-showcase.
Fixed by #1332
/close
from backstage-showcase.
@rm3l: Closing this issue.
In response to this:
Fixed by #1332
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
from backstage-showcase.
Related Issues (20)
- Fail the build if the yarn.lock file is changed after running yarn install HOT 7
- Fix Scalprum deprecation warning
- What is app-config.dynamic-plugins.yaml used for? HOT 4
- Provide Share Documentation for best practices to maintain the postgres database with the janus
- Unsatisfied version warnings from Scalprum
- backstage-showcase "not found" error handler doesn't work for plugin endpoints
- Impossible to dynamically load a number of upstream backend plugins
- Janus future
- Support to register scaffolderPlugin.provide(createScaffolderFieldExtension( for dynamic plugin HOT 15
- Add new tab EntityPage for the QuarkusConsole page HOT 9
- Allow adding a new Entity tab through dynamic plugin configuration HOT 1
- Branding: ability to customise the width of sidebar logo
- Config issue or bug ... using ArgoCD HOT 2
- Github auth is requested even if we chose as auth provider: guest HOT 3
- yarn: TypeError: true is not iterable! using a dynamic plugin
- turbo configuration issue when creating a new back-end plugin HOT 1
- The link of community slack channel is invalid
- Broken links to plugins (e.g., PagerDuty) in the main README.md file HOT 3
- An extension point on the frontend for Catalog Customization
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backstage-showcase.