Giter VIP home page Giter VIP logo

Comments (7)

mbrukman avatar mbrukman commented on May 14, 2024

Thanks for the report and sorry for the trouble! That looks like a bug in JanusGraph.

As part of the migration from the name Titan to JanusGraph, we replaced all code and constances from titan-* to janusgraph-* but we did not set compatible versions, so we need to update GraphDatabaseConfiguration.java as well as JanusGraphConstants.java to do the following:

  • allow titan-version as a valid configuration key for backwards-compatibility with Titan
  • allow janusgraph-version as a valid config key for folks who start with JanusGraph
  • set up compatible versions both for Titan 1.0 as well as JanusGraph 0.1.0-SNAPSHOT

If you're up for making these changes, we'd love to accept your contribution! Otherwise, we'll need someone to pick this up to fix this issue.

from janusgraph.

rafatuita avatar rafatuita commented on May 14, 2024

Sure, I'll pick it up tomorrow and send a fix

from janusgraph.

mbrukman avatar mbrukman commented on May 14, 2024

@rafatuita — thanks!

Please note that we'll need you (or an authorized officer of your company) to sign either the ICLA or CCLA, as appropriate, before we can accept any contributions.

from janusgraph.

rafatuita avatar rafatuita commented on May 14, 2024

got the fix ready, the approach I took was to go first on JanusGraph version, try/catch for the exception and look or a compatibility with titan and their versions, so it always tries janus first, if fails, go compatible check.

janusgraph.compatible.versions are stored on main pom.xmlfile, so I just added titan.backward.compatible.versions with those IDs 1.0.0,1.1.0-SNAPSHOT.

Since this is just a compatibility issue, didn't see a reason to work on this https://github.com/JanusGraph/janusgraph/blob/ec441ac6d87f3359c9740075786ec6de3651745e/janusgraph-dist/src/release/release.sh

let me know your thoughts.

from janusgraph.

twilmes avatar twilmes commented on May 14, 2024

@rafatuita good work on this one, can we close it out at this point?

from janusgraph.

rafatuita avatar rafatuita commented on May 14, 2024

@twilmes sure, you can close it by now.

from janusgraph.

twilmes avatar twilmes commented on May 14, 2024

Thanks @rafatuita. Closing as fixed by #80.

from janusgraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.