Comments (4)
ShaheedHaque
commented on August 25, 2024
1
OK. I propose to add an entry to the change history describing the change and push the release out in the coming days...
from calendra.
ShaheedHaque
commented on August 25, 2024
Thanks for the invite. I've just accepted but before I try to cut the
release, did you see my note about the "original" observance shifts? I
thought I'd double check since this is a definite behaviour change w.r.t
previous versions (and Workalendar) and probably needs an entry in
CHANGES.rst?
P.S. And thanks for the kind words... I can only say I learnt from the best!
…On Mon, 4 Jan 2021 at 01:06, Jason R. Coombs ***@***.***> wrote:
@ShaheedHaque <https://github.com/ShaheedHaque>, I've invited you as a
collaborator on this project. With the integrated CI, and with the
changelog up-to-date, all that's needed to cut a release is to tag it (i.e. git
tag -a -m "" v7.0.0). Would you care to do the honors?
Although you don't need access to PyPI in order to cut releases, I'd also
like to grant you maintainer access there as well in case a manual release
is needed and to reduce the bus factor on the project. Just let me know
your userid there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFHWKNOYCA4CUQC2CYCZRTSYEIAPANCNFSM4VSKLL4A>
.
from calendra.
jaraco
commented on August 25, 2024
I have seen the note and I've not had the time to fully absorb the implications. I should probably go back to that PR and double-check the tests. If the tests pass as found on workalendar, then I'm comfortable with it. If the tests had to be changed to pass, then I'd be concerned. It's important that the tests reflect the intention, which can be different for calendra (model the holiday on its declared day and separately model its observed date). I hope to take a look at that at some point, but honestly, I'm okay with the release going out and fixes to land later.
from calendra.
ShaheedHaque
commented on August 25, 2024
@jaraco OK, I created/pushed the tag, and saw some automation run. I just created user "srhaque" on PyPI.org. Do let me know if I need to do anything else!
from calendra.
Related Issues (12)
- 'int' object has no attribute 'year' HOT 8
- Implicit dependency on setuptools
- UK Boxing Day should be 2020-12-28, not 2020-12-26 HOT 3
- Sync with Workalendar 14
- Resync with upstream v16.1? HOT 4
- Bosnia HOT 1
- Do not apply "floating monday" holidays by default to western calendars
- Finnish fixed holidays are moved to the next monday if they occur on the weekend HOT 3
- Independence day observed on Friday when indicated on Saturday HOT 1
- TypeError in version resolution
- UK change to 2020 early May bank holiday HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calendra.