Comments (11)
oh right now it only looks for vim
, I will also have it check vi
.
from git-peek.
I changed my EDITOR to "vim" but still have the same problem.
from git-peek.
I just pushed a fix about 10 seconds ago ("version": "1.1.10"
) Let me know if that fixes it!
from git-peek.
One thing I'm unsure of: it logs a few messages after opening the editor, which appears in vim on top of vim
's text.
Is it better if I silence the logs for vim/vi?
from git-peek.
The new version works. Thanks.
Yeah, I noticed that too. I think it's better to open the editor after you've fetched the repo.
Another issue that I'm having is that I only see the README file and no other files.
from git-peek.
It would be a lot slower to wait for the entire repository to download, but I see what you're saying – it only shows the README file because it hasn't finished downloading the rest of the repository by the time vim opens and vim doesn't automatically refresh the directory listing (unlike VSCode/Sublime Text/others)
I guess what I could do instead is make it open the readme on vim by default (or linked file), so that if you want to go to a different file, when you go up, its probably loaded most of the files by then.
If it delayed opening until the repository is completely finished, it wouldn't be fast enough I think
from git-peek.
I'm personally fine with waiting for the whole repo to download before opening the editor.
The current behavior is a bit confusing.
from git-peek.
I tried it with "version": "1.1.15"
and the issue still persists when $EDITOR
is vim
. For now i'm just using git peek -e code
from git-peek.
@rushi can you screenshot/paste terminal output? I'm not sure how to reproduce.
One issue I'm seeing on macOS is that $EDITOR
isn't propagating to the node
process. It sounds like something related to System Integrity Protection, which is unfortunate.
from git-peek.
@rushi can you screenshot/paste terminal output? I'm not sure how to reproduce.
This is how it looks like when EDITOR=vim
for git peek https://github.com/Jarred-Sumner/git-peek
Technically the editor does open up, but the output is still on the CLI so it interferes with vim, and the vim UI doesn't refresh when new directories and such are fetched
One issue I'm seeing on macOS is that
$EDITOR
isn't propagating to thenode
process. It sounds like something related to System Integrity Protection, which is unfortunate.
/tmp
○ export EDITOR=code
/tmp
○ node test.js
process.env.EDITOR is code
/tmp
○ export EDITOR=vim
/tmp
○ node test.js
process.env.EDITOR is vim
/tmp
○ node -v
v12.19.1
I justed on my environment and it's definitely being picked up by node v12
from git-peek.
@rushi @soheilpro I added a --wait
flag which waits for the entire repository to finish downloading & extracting before opening the editor. This flag is always enabled if the chosen editor is vi
/vim
, but otherwise defaults to disabled. So it should just work the way you expect now.
I justed on my environment and it's definitely being picked up by node v12
Hmm, I think you're right. I read this somewhere when investigating an $EDITOR
issue earlier. In any case, I manually tested it in vim after setting $EDITOR
to vim and it seems to work right
Please re-open the issue if you're still seeing any problems.
from git-peek.
Related Issues (20)
- Consider support to recognize repo's language to decide which editor to open HOT 1
- Pre-compiled `brew/git-peek` bloats the repository unnecessarily HOT 2
- Bad credentials? HOT 5
- Folder deleted before editor is closed HOT 2
- rmSync is not a function HOT 5
- [WSL] - Doesn't work with code-insiders HOT 5
- Open default GH branch HOT 3
- Add configuration for default $EDITOR override HOT 1
- brew install v npm HOT 1
- improve error message for unsupported EDITOR HOT 3
- macOS: problems on Big Sur (Intel) & BBEdit HOT 3
- can support download .git folder ? HOT 1
- URL handler not opening git-peak.app HOT 1
- Doesn't work with code-insiders HOT 1
- brew package HOT 6
- Feature Request: Open pull request in editor HOT 1
- Doesn't start on Fedora 33, ZSH, Node 14, yarn HOT 4
- [Feature Request] Configurable temp path HOT 1
- line 12: -S: command not found HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-peek.