Giter VIP home page Giter VIP logo

Comments (8)

jarrekk avatar jarrekk commented on July 23, 2024

Hi @ashutoshmjain

Thanks very much for your kind reply! It's comprehensive and valuable for me, I will consider it carefully and ask my friends, if I have questions I will ask for your advise 😄

About changing heading of Blog page, source code is at blog/blog.html line 11, edit this line to <h1>Latest Blog</h1>, I think your advise is nice and I will consider it.

And about icon question you asked me previous, I missed another place at index page career section, icons are located at time line, you can edit them whatever you like at file _data/careers.yml, there is icon attribute at each item.

Free free to ask me if you have any questions, thanks!

from jalpc.

ashutoshmjain avatar ashutoshmjain commented on July 23, 2024

Thanks .. it worked

While we are on this topic .. Here is one more suggestion

When we click on the Blog menu button on main page , it scrolls me down to blog section .. that has nothing but a link to blog page .. why don't we remove that section as it is unnecessary , and rather take the viewer directly to blog posts page ...

If its a technical requirement to scroll down the blog section , then we should provide something useful there .. for example a description of blogs and a little clickable button for 'more'. Alternatively we can display last three posts here .. Just a thought .. nothing mandatory :-)

from jalpc.

jarrekk avatar jarrekk commented on July 23, 2024

Thanks for your suggestion.

When I designed this theme, I made it as index page first, viewers could get information and links from index page, it's also website owner profile page, so I used sections and anchors to realize it, recently I optimized index page: reducing request times and compressing css/ js files, because it took long time get total data from index page.

I think your suggestion is very nice, viewers can go to posts page directly or see some latest posts' title and go to posts page by clicking title. Once I thought blog section was unnecessary and superfluous, but most viewers see posts from other websites or search engines, they can go to posts detail page directly from links, so I didn't make changes, anyway I will consider it.

BTW, if you want to change it to any of both methods, I am glad to help you realize it, it will not take long time to do it:)

from jalpc.

ashutoshmjain avatar ashutoshmjain commented on July 23, 2024

Thanks @jarrekk

I think removing the blog section altogether is a better idea. We can have the top link directly jump to blog page. Please help with code if it's not too much work. Else we can live with it -:)

Your new template looks very good. I guess I will migrate to it once I finish moving all my posts (from various sources ) to the blog. I think once I have the posts figured out , migration won't take much. The new site loads faster. The skills template is very innovative. Keep up the good work.

Cheers

from jalpc.

jarrekk avatar jarrekk commented on July 23, 2024

Hi @ashutoshmjain

I created a pull request to your repo just now, please check it, hope this will help you; and I think this new theme will be easy to merge, I made some changes to let others easier to use:)

Thanks!

from jalpc.

ashutoshmjain avatar ashutoshmjain commented on July 23, 2024

Thanks Jack @jarrekk
I will work on it tonight as I want to do it from command line. This is my first 'pull request merge' experience. Want to make sure I understand how it works :-)
Cheers

from jalpc.

jarrekk avatar jarrekk commented on July 23, 2024

OK, this'll be convenient for you to update and review:)

from jalpc.

ashutoshmjain avatar ashutoshmjain commented on July 23, 2024

Thanks .. It worked .. looking great

Cheers

from jalpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.