Comments (18)
You can't run commands in the filter prompt.
To get the commands prompt, press ]
. It's there in the help page.
from nnn.
I think the issue he's describing is different. If you click on the statusbar with the mouse then pretty much all other keybindings stop working.
I was able to reproduce it on my end. But haven't yet looked into what's causing it.
from nnn.
I see. It's been ages I have used the mouse with nnn. Reopened.
from nnn.
then pretty much all other keybindings stop working.
even ESC
doesnt exit filter mode? iirc it happened in my build too, it was related to the filtermode thing in that case...
from nnn.
even
ESC
doesnt exit filter mode?
It does, but the visual doesn't update. And sometimes clicking on the statusbar doesn't even enable filter mode. And sometimes it shows filter mode being activated but it actually isn't. Something seems to be going pretty wrong somewhere.
from nnn.
By trying to reproduce the issue, I came across the following behaviour:
- When activating filter mode using the mouse, and then disabling it by pressing the escape key, filter mode is from then on automatically activated when changing directories.
- When activating filter mode using the forward-slash ('/') key, clicking on the prompt once doesn't de-activate it, rather requiring two successive clicks in order to turn filter mode off. In fact, if the escape key is pressed after clicking on the prompt once, the aforementioned problem arises again: changing directories triggers filter mode.
So, is this what is being discussed here? Is it an entirely separate problem? Is it actually intended behaviour and I'm just dumb?
from nnn.
When activating filter mode using the mouse, and then disabling it by pressing the escape key, filter mode is from then on automatically activated when changing directories.
Do you use the program option -n
?
from nnn.
As per the wiki mouse options:
Left single/double on last 2 rows Toggle type-to-nav
from nnn.
Do you use the program option
-n
?
No, I don't. I didn't even know about type-to-nav
. It is indeed intended behaviour and not what this issue is about. I apologize.
from nnn.
@7ocb or @azuline could any of one you have a look at this if you have the time?
from nnn.
Git bisect shows 2ac22cf to be the commit that introduced the issue. Not really sure what's going on tbh, the mouse handling code seems pretty complicated.
from nnn.
Thanks @N-R-K!
@0xACE can you please have a look?
from nnn.
@N-R-K The intended behaviour is: if type-to-nav mode is on, single or double click on the last 2 rows should disable it and vice versa.
I don't see anything mentioned about just the filter being on or off. Maybe we can toggle that also but in that case the filter should not show when disabled.
from nnn.
oh this happening to me too; commented out so much still couldn't get rid of it; now i know why, silly mouse ...
what a relief commented out clicking last 2 lines ...
from nnn.
Did a bit more debugging on this. In here, it receives another KEY_MOUSE
and exits out of the filterentries()
function for whatever reason:
Lines 3387 to 3389 in e76d7bb
log:
ln 3363: __func__=filterentries
ln 3388: *ch=409
ln 3389: keyname(*ch)=KEY_MOUSE
@jarun can we just remove this feature? It's been broken for ~4 years and almost no one noticed - meaning no one actually uses it.
from nnn.
Actually I use it on my smartphone and the touch works there! :)
It's super-easy to toggle between filter/non-filter modes that way.
Can you please check if just single/double click works? That is - whether commenting out any of the below snippets work:
7001 /* Toggle filter mode on left click on last 2 lines */
7002 if (event.y >= xlines - 2 && event.bstate == BUTTON1_PRESSED) {
7003 clearfilter();
7004 cfg.filtermode ^= 1;
7005 if (cfg.filtermode) {
7006 presel = FILTER;
7007 goto nochange;
7008 }
7009
7010 /* Start watching the directory */
7011 watch = TRUE;
7012 copycurname();
7013 cd = FALSE;
7014 goto begin;
7015 }
OR
7057 } else {
7058 if (cfg.filtermode || filterset())
7059 presel = FILTER;
7060 copycurname();
7061 goto nochange;
7062 }
from nnn.
@N-R-K and others, can you please check if the following patch works? (Ignore the changes due to trailing spaces).
diff --git a/src/nnn.c b/src/nnn.c
index d0938b99..dc3d7cf2 100644
--- a/src/nnn.c
+++ b/src/nnn.c
@@ -1312,14 +1312,14 @@ static char *abspath(const char *filepath, char *cwd, char *buf)
}
/* finds abspath of link pointed by filepath, taking cwd into account */
-static char *bmtarget(const char *filepath, char *cwd, char *buf)
+static char *bmtarget(const char *filepath, char *cwd, char *buf)
{
char target[PATH_MAX + 1];
ssize_t n = readlink(filepath, target, PATH_MAX);
if (n != -1) {
target[n] = '\0';
return abspath(target, cwd, buf);
- }
+ }
return NULL;
}
@@ -3436,6 +3436,11 @@ static int filterentries(char *path, char *lastname)
continue;
#ifndef NOMOUSE
case KEY_MOUSE:
+ MEVENT event = {0};
+ getmouse(&event);
+ if (event.bstate == 0)
+ continue;
+ ungetmouse(&event);
goto end;
#endif
case ESC:
from nnn.
Appears to be fixed for good in my tests.
@N-R-K @luukvbaal would it be possible to add a check in Makefile or PR CI to detect trailing blank spaces?
from nnn.
Related Issues (20)
- Current selection does not change to newly created dir, if current working directory path contains a symlink HOT 2
- Opening the help screen corrupts global variables HOT 4
- Can't get jump to command or autojump plugin to work HOT 3
- Preview-tui plugin throws syntax error HOT 3
- U+E5FF / / question mark box HOT 4
- NNN_TRASH_CUSTOM setting not working HOT 4
- preview-tabbed - zathura not focusing HOT 2
- Nerd fonts cause misaligned columns in detail mode with names first HOT 5
- nnn compiled with nerdfonts not displaying correctly in WSL HOT 2
- NNN broken on master HOT 3
- 'size missing' when trying to preview-tui in tmux HOT 7
- NNN does not close Tmux pane on opening a file while preview HOT 5
- Can't batch rename files which names start with dash '-' HOT 6
- mv: unrecognized option '--cp' HOT 2
- Icons does not work when NNN is opened with -C option HOT 5
- preview-tui: mpv HOT 11
- Syntax error with prescribed split-pane script HOT 7
- tabs content colorization is not working (zsh+tmux) HOT 3
- preview-tui does not work with tmux 3.4 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nnn.