malloc: error pointer being freed was not allocated about nnn HOT 9 CLOSED

I am unable to reproduce on Ubuntu. Can you please debug further to figure out which pointer is being freed without allocation?

from nnn.

This is coming from commit 3665541 and the next one.

@N-R-K can you please have a look?

from nnn.

Can we write directly to fd instead of having the temporary buffer?

from nnn.

Please confirm that the fix works.

from nnn.

This looks like a duplicate of #1768

It should be fixed in master. @XhstormR Can you try master branch and confirm?

This is coming from commit 3665541 and the next one.

@jarun I'm pretty sure that that is the commit that fixed the issue. be6988d should not be necessary.

from nnn.

Can we write directly to fd instead of having the temporary buffer?

Making a syscall for each and every byte seems unnecessary waste of resources to me.

IMO be6988d should be reverted since the bug was already fixed.

OP was using v4.9 instead of master branch. Maybe we can cut a new release soon?

from nnn.

I reproduced this one master (using fastmac) before attempting the fix.

As for a syscall overhead, I will add a new version to use dprintf.

from nnn.

I reproduced this one master (using fastmac) before attempting the fix.

Interesting. I don't know how that's possible. The help string is 1832 bytes and the buffer is 2048 bytes. It has more than enough space.

As for a syscall overhead, I will add a new version to use dprintf.

dprintf also makes 1 write syscall per call since dprintf uses file-descriptor directly without any buffering.

You'd need to use a FILE * with fopen + fwrite etc to avoid many syscalls. Do you want to make that change yourself or should I open a PR later today?

from nnn.

Please raise the PR.

from nnn.