Clarify use of threading in README, please about python-mpv HOT 7 CLOSED

Fixed in eb8b6a0. As a small bonus, you now can also call the constructor with start_event_thread=False and call the resulting object's ._loop function yourself. That acts much like gtk.main. If for some reason you don't like threading at all, there is an out-of-date branch on this repo that contains python3 asyncio-based handling of events (which I ripped out because it was unportable and really awkward to use at no benefit).

from python-mpv.

Thanks. While I'd consider renaming ._loop since it's no longer being presented as a private method, what you've done so far definitely resolves this.

Once I have time to work this into some of my projects as a replacement for an awkward, organically overgrown "call mpv in a subprocess once per file" system, I'll probably offer up a few improvements to the docs to cover what I learn from poking at it more.

from python-mpv.

I can no longer see the asyncio branch

from python-mpv.

True. I wonder where that went. I must have deleted it during some rebasing action. If you really need it, I can pull it out of an old backup.

from python-mpv.

Looks like the event thread plays nice with my script which leverages asyncio, so I won't be needing it - I was mostly curious what it looked like.

Anyway, the README file still refers to that branch, so you might want to correct that.
Thanks

from python-mpv.

Done.

The basic layout was that libmpv has some function that produces a sort of event fd that gets a single byte written to or something on every event received, and you could pass that into asyncio's event loop to wake up the event handler on every event.

from python-mpv.

Thank for the report 😸

from python-mpv.