Persisted queries? about apollo-upload-client HOT 12 CLOSED

Sorry thats a yes! Instead of reinventing the wheel here and across all the other http link packages, we will have an Apollo maintained package of helpers to use for most of the implementation.

from apollo-upload-client.

I'm not sure. Doesn't it just replace the query with a hash?

from apollo-upload-client.

Yeah it should, but I'm still seeing the full query being sent over the wire all the time!

from apollo-upload-client.

Here are the changes I've made:

1. Added a persisted query store to Engine:

new Engine({
   engineConfig: {
+    stores: [
+      {
+        name: 'pq',
+        inMemory: {
+          cacheSize: '5000000',
+        },
+      },
+    ],
+    persistedQueries: {
+      store: 'pq',
+    },
   },
 });

2. Added apollo-link-persisted-queries:

+ import { createPersistedQueryLink } from 'apollo-link-persisted-queries';
 
- const httpLink = createUploadLink({ /* ...  */ });
+ const httpLink = createPersistedQueryLink().concat(
+   createUploadLink({ /* ... */ })
+ );

Then I open my frontend and look in the dev tools, and what I see is this:

Every single API request still sends the entire query text to the server 😕 /cc @jbaxleyiii

from apollo-upload-client.

@mxstbr @jaydenseric ah yes! Here is the solution that will need to be implemented in the upload client:

The persisted query link sets a couple items on the context (https://github.com/apollographql/apollo-link-persisted-queries/blob/master/src/index.ts#L128-L131). These are used to tell downstream network (ws, upload, http) that we want to not send the operation, but instead send the extensions.

Network links can then read them and do this and this to attach the payload correctly.

Happy to help with any questions!

from apollo-upload-client.

@jaydenseric also, I'm wondering if you could implement the upload portion of this library as a custom fetcher for http-link that way you don't have to keep things in sync?

https://www.apollographql.com/docs/link/links/http.html#custom

from apollo-upload-client.

@jbaxleyiii I think that might not work, because the File and FileList instances in variables would have been lost when the request body was JSON encoded.

from apollo-upload-client.

@jaydenseric can we add support for persisted queries anyways by adding those options to the context, even if it can't be a custom fetcher?

from apollo-upload-client.

The way forward is to use apollo-link-utilities once it has stabilised in this PR.

from apollo-upload-client.

Is that a yes or a no? 😆

from apollo-upload-client.

Oh I see, thanks! Can't wait ✨

from apollo-upload-client.

@mxstbr would you like to verify this works as expected with [email protected]?

from apollo-upload-client.