Giter VIP home page Giter VIP logo

Comments (2)

mike-marcacci avatar mike-marcacci commented on June 4, 2024 1

It looks like version 3 of graphql-upload (apollo-upload-server) introduced v2 of the spec, which means that you will have to deal with a field name change and a change in field ordering. From the perspective of the spec, this is a breaking change. It was released only a couple months after the first version was published, so I suspect that a migration path was not an important criteria (and honestly this is the first case of this that I've seen in the many years I've been following this).

The only real solution here without updating the clients is to add a layer that detects and translates the spec v1 request into a v2 spec request. You mentioned you're using the JS libraries so this should be quite practical to do, but certainly isn't trivial:

  1. detect a multipart GraphQL request
  2. take ownership of the request stream without yet calling graphql-upload
  3. create a new stream in place of the real request stream
  4. begin consuming the request stream, buffering its contents into memory
  5. if you detect that the first part is named operations you know you have a v2 spec request:
    1. replay the contents from your buffer into your replacement stream
    2. pipe the rest of the request stream into your replacement stream
    3. allow graphql-upload to proceed as normal
  6. if you detect that the first part is named files you know you have a v1 spec request:
    1. buffer the entire files part into a new memory buffer
    2. once you detect the second part (which should be named operations) send any contents from the initial buffer and begin streaming the contents of the operations part to your replacement stream
    3. once the end of the operations part is reached, immediately replay the contents of the files buffer into the replacement stream
    4. pipe the remainder of the request into your replacement stream
    5. allow graphql-upload to proceed as normal

Again, this is non-trivial and probably represents a solid couple days of work, but is certainly doable if the scale of your operation demands it. This is obviously out of scope for the project at this point, but best of luck!

from graphql-multipart-request-spec.

jaydenseric avatar jaydenseric commented on June 4, 2024

It's a tricky situation; I've answered over here:

jaydenseric/graphql-upload#227 (comment)

from graphql-multipart-request-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.