Giter VIP home page Giter VIP logo

Comments (4)

tamagokun avatar tamagokun commented on July 30, 2024

I would submit a pull request, but I am completely confused by what is trying to be accomplished with the methods is_visible, has_dependencies and has_body

Shouldn't is_visible simply look something like:

public function is_visible() {
    return !empty($this->desc);
}

from phake.

jaz303 avatar jaz303 commented on July 30, 2024

Please pull and retry, there were some typos that slipped through. The test suite needs to be updated to exercise the task-listing code path.

Task list behaviour has been changed to include all tasks that have either bodies or dependents, regardless of whether a description has been set. We decided this was more useful behaviour, and will shortly be adding a hidden() helper for explicitly excluding tasks for the list.

from phake.

tamagokun avatar tamagokun commented on July 30, 2024

Cool, that did it. Thanks!

from phake.

clue avatar clue commented on July 30, 2024

This bug is also being addressed in #34, along with a bunch of unit tests.

from phake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.