Giter VIP home page Giter VIP logo

Comments (1)

Asday avatar Asday commented on August 28, 2024 1

I feel like this is a bug in django.

https://github.com/django/django/blob/1.10.1/django/views/debug.py#L40

The algorithm checks the variable name for sensitivity, then descends into nested dictionaries, checking for sensitivity at each level.

If any of the levels are deemed non-sensitive, the path ends there, and everything is returned verbatim.

In my mind, it should completely traverse nested dictionaries, stopping when it censors something, instead of when it doesn't, for instance:

MIXED_SENSITIVITY_DATA = {
    'secret_sensitive_data':  'foo',
    'mixed_sensitivity_nested': {
        'secret_sensitive_data': {
            'everything_in_here': 'will_be_censored',
        },
        'non_secret_data': 'baz',
    }
}

would become

MIXED_SENSITIVITY_DATA = {
    'secret_sensitive_data':  '**********',
    'mixed_sensitivity_nested': {
        'secret_sensitive_data': '**********',
        'non_secret_data': 'baz',
    }
}

as opposed to what it becomes now:

screen shot 2016-09-15 at 12 28 49

It's possible to work around this without resorting to environment variables or similar, by adding the following somewhere in the project that gets run. I put it in settings.py.

from django.views import debug
import re
debug.HIDDEN_SETTINGS = re.compile(
    debug.HIDDEN_SETTINGS.pattern + '|PAYMENT_VARIANTS',
    flags=re.IGNORECASE,
)

screen shot 2016-09-15 at 12 33 05

But this feels VERY subversive.

from django-payments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.