Comments (1)
I feel like this is a bug in django.
https://github.com/django/django/blob/1.10.1/django/views/debug.py#L40
The algorithm checks the variable name for sensitivity, then descends into nested dictionaries, checking for sensitivity at each level.
If any of the levels are deemed non-sensitive, the path ends there, and everything is returned verbatim.
In my mind, it should completely traverse nested dictionaries, stopping when it censors something, instead of when it doesn't, for instance:
MIXED_SENSITIVITY_DATA = {
'secret_sensitive_data': 'foo',
'mixed_sensitivity_nested': {
'secret_sensitive_data': {
'everything_in_here': 'will_be_censored',
},
'non_secret_data': 'baz',
}
}
would become
MIXED_SENSITIVITY_DATA = {
'secret_sensitive_data': '**********',
'mixed_sensitivity_nested': {
'secret_sensitive_data': '**********',
'non_secret_data': 'baz',
}
}
as opposed to what it becomes now:
It's possible to work around this without resorting to environment variables or similar, by adding the following somewhere in the project that gets run. I put it in settings.py
.
from django.views import debug
import re
debug.HIDDEN_SETTINGS = re.compile(
debug.HIDDEN_SETTINGS.pattern + '|PAYMENT_VARIANTS',
flags=re.IGNORECASE,
)
But this feels VERY subversive.
from django-payments.
Related Issues (20)
- Possible Improvement HOT 3
- Can't make Paypal payment, "You've been inactive for a while..." HOT 4
- Unable to Access Latest Version of django-payments HOT 2
- Dummy provider does not set captured_amount HOT 2
- BUG: Stripe V3 - 'Payment' object has no attribute 'billing_last_nane' HOT 1
- Stripe V3 - Received unknown parameter: customer_data. Did you mean customer_update? HOT 6
- Stripe v3 setup instructions HOT 11
- v3.0.0 is not on PyPI HOT 11
- Inconsistent usages of "Backend" and "Provider" HOT 1
- Stripe payment field typo. HOT 1
- Trying to access master database in slave state HOT 1
- Reverse for 'process_payment' not found. 'process_payment' is not a valid view function or pattern name. HOT 1
- Stripe refund flow.
- `Payment.refund()` does not refund HOT 2
- M HOT 1
- How to pass an item reference to the `Payment.get_purchased_items` method? HOT 1
- Create a Provider Class example raises an exception HOT 3
- Is there a preferred way to implement discount codes? HOT 1
- Manually following process URL results in a crash HOT 2
- Django 5.0 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-payments.