Giter VIP home page Giter VIP logo

Comments (6)

patrys avatar patrys commented on August 28, 2024

Huh, the base PaymentForm has exactly that: https://github.com/mirumee/django-payments/blob/master/payments/forms.py#L23

Something is not right. What type is the object returned?

from django-payments.

cdvv7788 avatar cdvv7788 commented on August 28, 2024

action is None. I don't know if it is related to validation or something.
payment.get_form() for stripe provider returns payments.stripe.forms.ModalPaymentForm, however no action is defined.
It seems https://github.com/mirumee/django-payments/blob/master/payments/forms.py#L36 is overriding that somehow. The action argument is getting lost somewhere.

from django-payments.

cdvv7788 avatar cdvv7788 commented on August 28, 2024

I would say change action=None to action='', as that is intended to be the default setting. What are the backends that should return an action other than blank?

from django-payments.

patrys avatar patrys commented on August 28, 2024

You are right, it sets action to None by default which never makes sense.

from django-payments.

patrys avatar patrys commented on August 28, 2024

Should be fixed with 0.8.2. Thanks for reporting!

from django-payments.

cdvv7788 avatar cdvv7788 commented on August 28, 2024

Nice. Thanks.

from django-payments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.