pgmagick image quality about sorl-thumbnail HOT 8 CLOSED

Interesting, do you have some files I can test?

from sorl-thumbnail.

I think I might be experiencing the same issue here.

Original image:
http://cdn.perth2011.thecut.net.au/uploads/media/images/2011/12/07/PAULPRK25315.jpg

Sorl thumbnail output:
http://cdn.perth2011.thecut.net.au/cache/cd/ac/cdacf46b8c7133f854c0281352fa7290.jpg

from sorl-thumbnail.

Hi.

I think that the problem has occurred since Image.type() and Image.quantize() are used simultaneously.
But, I don't prove it. Could you check once?

now:

    def _colorspace(self, image, colorspace):
        if colorspace == 'RGB':
            image.type(ImageType.TrueColorMatteType)
            image.quantizeColorSpace(ColorspaceType.RGBColorspace)
        elif colorspace == 'GRAY':
            image.type(ImageType.GrayscaleMatteType)
            image.quantizeColorSpace(ColorspaceType.GRAYColorspace)
        else:
            return image
        image.quantize()
        return image

fix:

    def _colorspace(self, image, colorspace):
        if colorspace == 'RGB':
            image.type(ImageType.TrueColorMatteType)
        elif colorspace == 'GRAY':
            image.type(ImageType.GrayscaleMatteType)
        else:
            return image
        return image

reference: http://www.graphicsmagick.org/Magick++/Image.html

  image.quantizeColorSpace( GRAYColorspace );
  image.quantizeColors( 256 );
  image.quantize( );
  
  or, more simply:
  
  image.type( GrayscaleType );

Thanks.

from sorl-thumbnail.

Thanks hhatto, that did the trick!

from sorl-thumbnail.

Nice! Please make patch or pull req. if possible at all try to make a test too :)

from sorl-thumbnail.

Can you please just try it so that it does infact make a grayscale image from a color one?

from sorl-thumbnail.

Confirming that specifying colorspace="GRAY" still greyscales a color image.

from sorl-thumbnail.

Thanks! & thanks hhatto for pgmagick!

from sorl-thumbnail.