Comments (5)
Hey Nordsoft,
Thanks for reporting this. I'll give it a shot on Linux when I next put some time into this.
Just to check, are you compiling with C++17 features enabled on your compiler? I setup CMake to enable it but I'm not sure it works on all environments.
from inkcpp.
@brwarner Just tested out Github Actions for Windows, Linux and MacOS.
https://github.com/2shady4u/inkcpp/actions
Seems there's still some work to make the code truly platform-agnostic.
PS: This fork uses the scons build system instead of cmake
to generate platform-dependent build files. Unfortunately I don't have the proper knowledge/experience about cmake
to implement this in Github Actions... 🤔
from inkcpp.
@brwarner, yes, C++17 used. Quick review has shown:
- There are some platform-specific functions you use, e.g. _itoa_s.
- Template specialization should be out of class definition
- std::exception doesn't receive std::string in ctor, better to use std::runtime_error or std::logic_error (or create own expectation inherits std::exception)
from inkcpp.
Thanks. I'm part way there in the new platform
branch. There's some sticky template shenanigans that I'm having trouble parsing but I'll take a look at them next time.
from inkcpp.
With some help from JBrenda this should now compile on Linux. There may be other issues, which I'll try to look into.
from inkcpp.
Related Issues (20)
- String Comparison Unit Test Failing on Linux HOT 5
- inkcpp_test does not compile on M1 / arm64 HOT 5
- Difficult distribution structure for non-Unreal install HOT 5
- Test fails on Debug configuration HOT 4
- Runner doesn't break on newlines between knots/stitches HOT 6
- Introducing C bindings HOT 1
- Crash with Tags HOT 4
- inklecate location HOT 1
- C++ exports for UE plugin HOT 1
- Fully-bracketed choices followed by a single space causes an assertion error HOT 5
- Bracketed choices which don't have content before their brackets error when a subsequently nested third-level choice is encountered HOT 1
- Windows Defender false positive on win64-cl.zip and inkcpp_cl.exe
- Variables are not re-evaluated after lookahead HOT 2
- Conditional diverts are not properly handled with whitespace HOT 4
- UE Marketplace Release HOT 1
- Heads up: no arm64 code in latest binary release/download for macos HOT 3
- crime scene example story throws "Operation for value not supported!" HOT 3
- Errorneous newline inserted in some text. HOT 6
- How to serialize entire story to a graph? HOT 13
- Inklecate failed with exit code 1 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inkcpp.